Skip to content

feat(autofix): Update seer explorer autofix last triggered on completion #111663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zylphrex merged 9 commits into from
Mar 30, 2026
Merged

feat(autofix): Update seer explorer autofix last triggered on completion #111663

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7863cbb
feat(autofix): Update seer explorer autofix last triggered on completion
Zylphrex Mar 26, 2026
07df567
Merge branch 'master' into txiao/feat/update-seer-explorer-autofix-la…
Zylphrex Mar 27, 2026
4f0e02a
filter on org id as well
Zylphrex Mar 27, 2026
564a21c
remove None type from group
Zylphrex Mar 27, 2026
b156fec
fix tests
Zylphrex Mar 27, 2026
20c11de
Merge branch 'master' into txiao/feat/update-seer-explorer-autofix-la…
Zylphrex Mar 27, 2026
9d10fc3
Merge branch 'master' into txiao/feat/update-seer-explorer-autofix-la…
Zylphrex Mar 27, 2026
383d741
bump automation dispatched ttl to 30 minutes
Zylphrex Mar 27, 2026
0d3ffce
Merge branch 'master' into txiao/feat/update-seer-explorer-autofix-la…
Zylphrex Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/sentry/seer/autofix/autofix_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from enum import StrEnum
from typing import TYPE_CHECKING, Literal

from django.utils import timezone
from pydantic import BaseModel

from sentry.seer.autofix.artifact_schemas import (
Expand Down Expand Up @@ -247,8 +246,6 @@ def trigger_autofix_explorer(
artifact_schema=artifact_schema,
)

group.update(seer_explorer_autofix_last_triggered=timezone.now())

payload = {
"run_id": run_id,
"group_id": group.id,
Expand Down
73 changes: 27 additions & 46 deletions src/sentry/seer/autofix/on_completion_hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import logging
from typing import TYPE_CHECKING

from django.utils import timezone

from sentry import features
from sentry.models.group import Group
from sentry.models.organization import Organization
Expand Down Expand Up @@ -76,13 +78,20 @@
)
return

group_id = state.metadata.get("group_id") if state.metadata else None
if group_id is None:
return

group = Group.objects.get(id=group_id, project__organization_id=organization.id)

Check failure on line 85 in src/sentry/seer/autofix/on_completion_hook.py

View check run for this annotation

@sentry/warden / warden: sentry-backend-bugs

[95N-HVM] Unhandled Group.DoesNotExist in on_completion_hook.execute (additional location) 

Line 85 calls `Group.objects.get(id=group_id, ...)` without handling `DoesNotExist`. If the group is deleted between when the autofix run was triggered and when the completion hook fires, this raises an unhandled exception. The refactoring removed the `DoesNotExist` handling that previously existed in `_maybe_trigger_supergroups_embedding` (lines 233-242 in old code) and `_maybe_continue_pipeline` (lines 319-332 in old code) without adding equivalent handling in `execute`.
Comment thread
sentry-warden[bot] marked this conversation as resolved.
Copy link
Copy Markdown
Contributor

@sentry sentry Bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The Group.objects.get() call lacks exception handling. If a group is deleted mid-process, the hook will fail and abort subsequent steps.
Severity: MEDIUM

Suggested Fix

Wrap the Group.objects.get(id=group_id, ...) call in a try/except Group.DoesNotExist block. Inside the except block, log a warning and return gracefully, similar to how the previous version of the code handled this case.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/sentry/seer/autofix/on_completion_hook.py#L85

Potential issue: The `Group.objects.get()` call at line 85 is not wrapped in a
`try/except` block. If a group is deleted between when an autofix is triggered and when
the completion webhook fires, a `Group.DoesNotExist` exception will be raised. This
unhandled exception propagates up and causes the entire hook to abort. As a result,
subsequent actions like sending completion webhooks, continuing the autofix pipeline,
and triggering supergroup embeddings will not execute. This is a regression from the
previous implementation, which defensively handled this known scenario.

Did we get this right? 👍 / 👎 to inform future reviews.

Comment thread
cursor[bot] marked this conversation as resolved.
group.update(seer_explorer_autofix_last_triggered=timezone.now())
Comment thread
sentry[bot] marked this conversation as resolved.
Comment thread
cursor[bot] marked this conversation as resolved.

# Send webhook for the completed step
cls._send_step_webhook(organization, run_id, state)
cls._send_step_webhook(organization, run_id, state, group)

cls._maybe_trigger_supergroups_embedding(organization, run_id, state)
cls._maybe_trigger_supergroups_embedding(organization, run_id, state, group)

# Continue the automated pipeline if stopping_point hasn't been reached
cls._maybe_continue_pipeline(organization, run_id, state)
cls._maybe_continue_pipeline(organization, run_id, state, group)

@classmethod
def find_latest_artifact_for_step(cls, state: SeerRunState, key: str) -> Artifact | None:
Expand All @@ -95,19 +104,24 @@
return None

@classmethod
def _send_step_webhook(cls, organization, run_id, state: SeerRunState):
def _send_step_webhook(
cls,
organization: Organization,
run_id: int,
state: SeerRunState,
group: Group,
):
"""
Send webhook for the completed step.

Determines which step just completed and sends the appropriate webhook event.
"""
current_step = cls._get_current_step(state)

webhook_payload = {"run_id": run_id}

group_id = state.metadata.get("group_id") if state.metadata else None
if group_id is not None:
webhook_payload["group_id"] = group_id
webhook_payload = {
"run_id": run_id,
"group_id": group.id,
}

# Iterate through blocks in reverse order (most recent first)
# to find which step just completed
Expand Down Expand Up @@ -213,25 +227,13 @@
organization: Organization,
run_id: int,
state: SeerRunState,
group: Group,
) -> None:
"""Trigger supergroups embedding if feature flag is enabled."""
current_step = cls._get_current_step(state)
if current_step != AutofixStep.ROOT_CAUSE:
return

group_id = state.metadata.get("group_id") if state.metadata else None
if group_id is None:
return

try:
group = Group.objects.get(id=group_id)
except Group.DoesNotExist:
logger.warning(
"autofix.supergroup_embedding.group_not_found",
extra={"group_id": group_id},
)
return

if not features.has("projects:supergroup-embeddings-explorer", group.project):
return

Expand All @@ -242,7 +244,7 @@
try:
trigger_supergroups_embedding(
organization_id=organization.id,
group_id=group_id,
group_id=group.id,

Check failure on line 247 in src/sentry/seer/autofix/on_completion_hook.py

View check run for this annotation

@sentry/warden / warden: sentry-backend-bugs

Unhandled Group.DoesNotExist in on_completion_hook.execute 

Line 85 calls `Group.objects.get(id=group_id, ...)` without handling `DoesNotExist`. If the group is deleted between when the autofix run was triggered and when the completion hook fires, this raises an unhandled exception. The refactoring removed the `DoesNotExist` handling that previously existed in `_maybe_trigger_supergroups_embedding` (lines 233-242 in old code) and `_maybe_continue_pipeline` (lines 319-332 in old code) without adding equivalent handling in `execute`.
project_id=group.project_id,
artifact_data=root_cause_artifact.data,
)
Expand All @@ -252,7 +254,7 @@
extra={
"run_id": run_id,
"organization_id": organization.id,
"group_id": group_id,
"group_id": group.id,
},
)

Expand Down Expand Up @@ -289,6 +291,7 @@
organization: Organization,
run_id: int,
state: SeerRunState,
group: Group,
) -> None:
"""
Continue to the next step if stopping_point hasn't been reached.
Expand All @@ -307,28 +310,6 @@
return

stopping_point = AutofixStoppingPoint(metadata["stopping_point"])
group_id = metadata.get("group_id")

if not group_id:
logger.warning(
"autofix.on_completion_hook.no_group_id_in_metadata",
extra={"run_id": run_id, "organization_id": organization.id},
)
return

# Get the group
try:
group = Group.objects.get(id=group_id, project__organization=organization)
except Group.DoesNotExist:
logger.warning(
"autofix.on_completion_hook.group_not_found",
extra={
"run_id": run_id,
"organization_id": organization.id,
"group_id": group_id,
},
)
return

if current_step is None:
logger.warning(
Expand Down
24 changes: 0 additions & 24 deletions tests/sentry/seer/autofix/test_autofix_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,30 +354,6 @@ def test_trigger_autofix_explorer_passes_group_id_in_metadata(
call_kwargs = mock_client.start_run.call_args.kwargs
assert call_kwargs["metadata"] == {"group_id": self.group.id, "referrer": "unknown"}

@patch("sentry.seer.autofix.autofix_agent.broadcast_webhooks_for_organization.delay")
@patch("sentry.seer.autofix.autofix_agent.SeerExplorerClient")
def test_trigger_autofix_explorer_updates_explorer_last_triggered(
self, mock_client_class, mock_broadcast
):
"""trigger_autofix_explorer sets seer_explorer_autofix_last_triggered on the group."""
mock_client = MagicMock()
mock_client_class.return_value = mock_client
mock_client.start_run.return_value = 123

assert self.group.seer_explorer_autofix_last_triggered is None

trigger_autofix_explorer(
group=self.group,
step=AutofixStep.ROOT_CAUSE,
referrer=AutofixReferrer.UNKNOWN,
run_id=None,
)

self.group.refresh_from_db()

assert self.group.seer_autofix_last_triggered is None
assert self.group.seer_explorer_autofix_last_triggered is not None


class TestTriggerCodingAgentHandoff(TestCase):
"""Tests for trigger_coding_agent_handoff function."""
Expand Down
36 changes: 17 additions & 19 deletions tests/sentry/seer/autofix/test_autofix_on_completion_hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,14 +199,14 @@ def setUp(self):
def test_maybe_continue_pipeline_no_metadata(self, mock_trigger):
"""Does not continue when metadata is missing."""
state = run_state(blocks=[root_cause_memory_block()])
AutofixOnCompletionHook._maybe_continue_pipeline(self.organization, 123, state)
AutofixOnCompletionHook._maybe_continue_pipeline(self.organization, 123, state, self.group)
mock_trigger.assert_not_called()

@patch("sentry.seer.autofix.on_completion_hook.trigger_autofix_explorer")
def test_maybe_continue_pipeline_no_stopping_point_in_metadata(self, mock_trigger):
"""Does not continue when stopping_point is missing from metadata."""
state = run_state(blocks=[root_cause_memory_block()], metadata={"group_id": self.group.id})
AutofixOnCompletionHook._maybe_continue_pipeline(self.organization, 123, state)
AutofixOnCompletionHook._maybe_continue_pipeline(self.organization, 123, state, self.group)
mock_trigger.assert_not_called()

@patch("sentry.seer.autofix.on_completion_hook.trigger_autofix_explorer")
Expand All @@ -219,7 +219,7 @@ def test_maybe_continue_pipeline_at_stopping_point(self, mock_trigger):
"stopping_point": AutofixStoppingPoint.ROOT_CAUSE.value,
},
)
AutofixOnCompletionHook._maybe_continue_pipeline(self.organization, 123, state)
AutofixOnCompletionHook._maybe_continue_pipeline(self.organization, 123, state, self.group)
mock_trigger.assert_not_called()

@patch("sentry.seer.autofix.on_completion_hook.get_project_seer_preferences")
Expand All @@ -236,7 +236,7 @@ def test_maybe_continue_pipeline_continues_to_next_step(self, mock_trigger, mock
"stopping_point": AutofixStoppingPoint.CODE_CHANGES.value,
},
)
AutofixOnCompletionHook._maybe_continue_pipeline(self.organization, 123, state)
AutofixOnCompletionHook._maybe_continue_pipeline(self.organization, 123, state, self.group)
mock_trigger.assert_called_once()
call_kwargs = mock_trigger.call_args.kwargs
assert call_kwargs["group"].id == self.group.id
Expand All @@ -257,7 +257,7 @@ def test_maybe_continue_pipeline_pushes_changes_for_open_pr(self, mock_push_chan
"stopping_point": AutofixStoppingPoint.OPEN_PR.value,
},
)
AutofixOnCompletionHook._maybe_continue_pipeline(self.organization, 123, state)
AutofixOnCompletionHook._maybe_continue_pipeline(self.organization, 123, state, self.group)
mock_push_changes.assert_called_once_with(self.group, 123, state=state)


Expand All @@ -284,6 +284,8 @@ class TestAutofixOnCompletionHookWebhooks(TestCase):
def setUp(self):
super().setUp()
self.organization = self.create_organization()
self.project = self.create_project(organization=self.organization)
self.group = self.create_group(project=self.project)

@patch("sentry.seer.autofix.on_completion_hook.broadcast_webhooks_for_organization.delay")
def test_send_step_webhook_artifact_types(self, mock_broadcast):
Expand Down Expand Up @@ -322,7 +324,7 @@ class TestCaseDict(TypedDict):
for i, test_case in enumerate(test_cases):
mock_broadcast.reset_mock()
state = run_state(blocks=[test_case["block"]])
AutofixOnCompletionHook._send_step_webhook(self.organization, run_id, state)
AutofixOnCompletionHook._send_step_webhook(self.organization, run_id, state, self.group)

mock_broadcast.assert_called_once()
call_kwargs = mock_broadcast.call_args.kwargs
Expand All @@ -346,7 +348,7 @@ def test_send_step_webhook_coding(self, mock_broadcast):
code_changes_memory_block(),
]
)
AutofixOnCompletionHook._send_step_webhook(self.organization, 123, state)
AutofixOnCompletionHook._send_step_webhook(self.organization, 123, state, self.group)

mock_broadcast.assert_called_once()
call_kwargs = mock_broadcast.call_args.kwargs
Expand All @@ -365,7 +367,7 @@ def test_send_step_webhook_no_artifacts_no_webhook(self, mock_broadcast):
artifacts=[],
)
state = run_state(blocks=[block])
AutofixOnCompletionHook._send_step_webhook(self.organization, 123, state)
AutofixOnCompletionHook._send_step_webhook(self.organization, 123, state, self.group)

mock_broadcast.assert_not_called()

Expand All @@ -385,7 +387,9 @@ def test_triggers_embedding_on_root_cause(self, mock_trigger_sg):
"""Triggers supergroups embedding when root cause completes with feature flag enabled."""
block = root_cause_memory_block()
state = run_state(blocks=[block], metadata={"group_id": self.group.id})
AutofixOnCompletionHook._maybe_trigger_supergroups_embedding(self.organization, 123, state)
AutofixOnCompletionHook._maybe_trigger_supergroups_embedding(
self.organization, 123, state, self.group
)

mock_trigger_sg.assert_called_once_with(
organization_id=self.organization.id,
Expand All @@ -401,15 +405,9 @@ def test_skips_embedding_when_flag_disabled(self, mock_trigger_sg):
blocks=[root_cause_memory_block()],
metadata={"group_id": self.group.id},
)
AutofixOnCompletionHook._maybe_trigger_supergroups_embedding(self.organization, 123, state)

mock_trigger_sg.assert_not_called()

@patch("sentry.seer.autofix.on_completion_hook.trigger_supergroups_embedding")
def test_skips_embedding_when_no_group_id(self, mock_trigger_sg):
"""Does not trigger supergroups embedding when group_id is missing from metadata."""
state = run_state(blocks=[root_cause_memory_block()])
AutofixOnCompletionHook._maybe_trigger_supergroups_embedding(self.organization, 123, state)
AutofixOnCompletionHook._maybe_trigger_supergroups_embedding(
self.organization, 123, state, self.group
)

mock_trigger_sg.assert_not_called()

Expand Down Expand Up @@ -553,7 +551,7 @@ def test_maybe_continue_pipeline_triggers_handoff_when_configured(
},
)

AutofixOnCompletionHook._maybe_continue_pipeline(self.organization, 123, state)
AutofixOnCompletionHook._maybe_continue_pipeline(self.organization, 123, state, self.group)

mock_trigger_handoff.assert_called_once()

Expand Down
Loading