ref(cells): RpcOrganizationSlugReservation uses cell_name on the wire#111597
Merged
ref(cells): RpcOrganizationSlugReservation uses cell_name on the wire#111597
Conversation
switches the wire format from "region_name" to "cell_name"
github-actions
bot
added
the
Scope: Backend
markstory
reviewed
Mar 26, 2026
| user_id: int | None | ||
| slug: str | ||
| region_name: str | ||
| cell_name: str |
Member
There was a problem hiding this comment.
There are still a few call sites that are using region_name. Shouldn't those be updated to use cell_name before we switch the wire format.
Member
Author
There was a problem hiding this comment.
you mean accessing the property .region_name?
that's fine since we still have this below:
@property
def region_name(self) -> str:
return self.cell_name
Member
There was a problem hiding this comment.
Yes, the serialize_slug_reservation function is creating instances of this model with region_name.
Member
Author
There was a problem hiding this comment.
yeah it works due to the root validator, but i had to change it anyway to make mypy happy
markstory
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flips the wire format from "region_name" to "cell_name". Alias is still present for deploy safety.