fix(preprod): Allow org auth tokens to access build install-details#111511
Open
runningcode wants to merge 1 commit intomasterfrom
Open
fix(preprod): Allow org auth tokens to access build install-details#111511runningcode wants to merge 1 commit intomasterfrom
runningcode wants to merge 1 commit intomasterfrom
Conversation
The public install-details endpoint inherited OrganizationPermission which only accepts org:read scope. Org auth tokens used in CI have org:ci scope, so sentry-cli build download failed while build upload worked. Switch to OrganizationReleasePermission which accepts org:ci, matching the permission class used by the upload endpoints. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public install-details endpoint (
/organizations/{org}/preprodartifacts/{id}/install-details/) inheritedOrganizationPermissionfromOrganizationEndpoint, which only acceptsorg:read,org:write, andorg:adminscopes. Org auth tokens used in CI typically haveorg:ciscope, sosentry-cli build downloadfailed at the install-details step whilebuild uploadworked fine (since upload endpoints useOrganizationReleasePermissionwhich acceptsorg:ci).This switches the endpoint to use
OrganizationReleasePermission, matching the permission class used by the upload/assemble endpoints.