Skip to content

ref(preprod): Restructure commit_comparison conditional to if/else#111500

Merged
mtopo27 merged 2 commits intomasterfrom
mtopo27/refactor-commit-comparison-conditional
Mar 30, 2026
Merged

ref(preprod): Restructure commit_comparison conditional to if/else#111500
mtopo27 merged 2 commits intomasterfrom
mtopo27/refactor-commit-comparison-conditional

Conversation

@mtopo27
Copy link
Copy Markdown
Contributor

@mtopo27 mtopo27 commented Mar 25, 2026

Summary

  • Flip the early-return guard if not artifact.commit_comparison: return into an if artifact.commit_comparison: ... else: log block
  • Pure structural change — no behavior difference
  • Prepares for a follow-up PR that adds logic to the else branch and after the if/else block

Test plan

  • No-op refactor; existing tests pass unchanged

@mtopo27 mtopo27 requested a review from a team as a code owner March 25, 2026 00:10
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 25, 2026
Flip the early-return guard `if not artifact.commit_comparison: return`
into an `if/else` block. This is a pure structural change with no
behavior difference, preparing for a follow-up that adds logic to the
else branch.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mtopo27 mtopo27 force-pushed the mtopo27/refactor-commit-comparison-conditional branch from f20d53c to 21a3f8c Compare March 26, 2026 21:58
Copy link
Copy Markdown
Contributor

@chromy chromy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mtopo27 mtopo27 merged commit b5166a2 into master Mar 30, 2026
64 checks passed
@mtopo27 mtopo27 deleted the mtopo27/refactor-commit-comparison-conditional branch March 30, 2026 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants