Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions static/app/gettingStartedDocs/dotnet/metrics.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ describe('metrics', () => {
});

expect(
screen.getByText(
textWithMarkupMatcher(/SentrySdk\.Experimental\.Metrics\.EmitCounter/)
)
screen.getByText(textWithMarkupMatcher(/SentrySdk\.Metrics\.EmitCounter/))
).toBeInTheDocument();
});

Expand All @@ -25,9 +23,7 @@ describe('metrics', () => {
});

expect(
screen.queryByText(
textWithMarkupMatcher(/SentrySdk\.Experimental\.Metrics\.EmitCounter/)
)
screen.queryByText(textWithMarkupMatcher(/SentrySdk\.Metrics\.EmitCounter/))
).not.toBeInTheDocument();
});
});
16 changes: 8 additions & 8 deletions static/app/gettingStartedDocs/dotnet/metrics.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ export const metricsVerify = (params: DocsParams): ContentBlock => ({
language: 'csharp',
code: `using Sentry;

SentrySdk.Experimental.Metrics.EmitCounter("button_click", 5,
SentrySdk.Metrics.EmitCounter("button_click", 5,
[new KeyValuePair<string, object>("browser", "Firefox"), new KeyValuePair<string, object>("app_version", "1.0.0")]);
SentrySdk.Experimental.Metrics.EmitDistribution("page_load", 15.0, MeasurementUnit.Duration.Millisecond,
SentrySdk.Metrics.EmitDistribution("page_load", 15.0, MeasurementUnit.Duration.Millisecond,
[new KeyValuePair<string, object>("page", "/home")]);
SentrySdk.Experimental.Metrics.EmitGauge("page_load", 15.0, MeasurementUnit.Duration.Millisecond,
SentrySdk.Metrics.EmitGauge("page_load", 15.0, MeasurementUnit.Duration.Millisecond,
[new KeyValuePair<string, object>("page", "/home")]);
`,
},
Expand All @@ -52,7 +52,7 @@ export const metrics: OnboardingConfig = {
{
type: 'text',
text: tct(
'Install our .NET SDK with a minimum version that supports metrics ([code:6.1.0] or higher).',
'Install our .NET SDK with a minimum version that supports metrics ([code:6.3.0] or higher).',
{
code: <code />,
}
Expand Down Expand Up @@ -84,7 +84,7 @@ export const metrics: OnboardingConfig = {
{
type: 'text',
text: tct(
'Metrics are automatically enabled in your [code:SentrySdk.Init] configuration. You can emit metrics using the [code:SentrySdk.Experimental.Metrics] API.',
'Metrics are automatically enabled in your [code:SentrySdk.Init] configuration. You can emit metrics using the [code:SentrySdk.Metrics] API.',
{
code: <code />,
}
Expand All @@ -100,11 +100,11 @@ SentrySdk.Init(options =>
options.Dsn = "${params.dsn.public}";
});

SentrySdk.Experimental.Metrics.EmitCounter("button_click", 5,
SentrySdk.Metrics.EmitCounter("button_click", 5,
[new KeyValuePair<string, object>("browser", "Firefox"), new KeyValuePair<string, object>("app_version", "1.0.0")]);
SentrySdk.Experimental.Metrics.EmitDistribution("page_load", 15.0, MeasurementUnit.Duration.Millisecond,
SentrySdk.Metrics.EmitDistribution("page_load", 15.0, MeasurementUnit.Duration.Millisecond,
[new KeyValuePair<string, object>("page", "/home")]);
SentrySdk.Experimental.Metrics.EmitGauge("page_load", 15.0, MeasurementUnit.Duration.Millisecond,
SentrySdk.Metrics.EmitGauge("page_load", 15.0, MeasurementUnit.Duration.Millisecond,
[new KeyValuePair<string, object>("page", "/home")]);`,
},
{
Expand Down
8 changes: 4 additions & 4 deletions static/app/gettingStartedDocs/dotnet/utils.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import type {DocsParams} from 'sentry/components/onboarding/gettingStartedDoc/types';
import {getPackageVersion} from 'sentry/utils/gettingStartedDocs/getPackageVersion';

// Sentry SDK for .NET 6.1.0 adds initial experimental support for Metrics
// Sentry SDK for .NET 6.3.0 adds stable APIs for Metrics
export const getInstallSnippetPackageManager = (params: DocsParams) => `
Install-Package Sentry -Version ${getPackageVersion(params, 'sentry.dotnet', '6.1.0')}`;
Install-Package Sentry -Version ${getPackageVersion(params, 'sentry.dotnet', '6.3.0')}`;

// Sentry SDK for .NET 6.1.0 adds initial experimental support for Metrics
// Sentry SDK for .NET 6.3.0 adds stable APIs for Metrics
export const getInstallSnippetCoreCli = (params: DocsParams) => `
dotnet add package Sentry -v ${getPackageVersion(params, 'sentry.dotnet', '6.1.0')}`;
dotnet add package Sentry -v ${getPackageVersion(params, 'sentry.dotnet', '6.3.0')}`;
Loading