ref(preprod): Remove graduated preprod-frontend-routes feature flag#110583
ref(preprod): Remove graduated preprod-frontend-routes feature flag#110583NicoHinderling merged 2 commits intomasterfrom
Conversation
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
d32dd26 to
dcfa111
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Unnecessary unrelated feature flag added to test fixture
- Replaced the unrelated organization feature flag in the releases list test fixture with an empty features array because the component no longer depends on any org-level flag.
Or push these changes by commenting:
@cursor push 5e62e07bb5
Preview (5e62e07bb5)
diff --git a/static/app/views/releases/list/index.spec.tsx b/static/app/views/releases/list/index.spec.tsx
--- a/static/app/views/releases/list/index.spec.tsx
+++ b/static/app/views/releases/list/index.spec.tsx
@@ -21,7 +21,7 @@
describe('ReleasesList', () => {
const organization = OrganizationFixture({
- features: ['search-query-builder-input-flow-changes'],
+ features: [],
});
const projects = [ProjectFixture({features: ['releases']})];
const semverVersionInfo = {This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
0c09bbe to
c20b115
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c20b115. Configure here.
Backend Test FailuresFailures on
|
The preprod-frontend-routes flag has been at 100% rollout and is fully graduated. Remove all gating code across backend endpoints, frontend components, and tests since all code paths are already executing in production.
74eab36 to
7378dbd
Compare


Followup to #109829
Summary
organizations:preprod-frontend-routesfeature flag which has been at 100% rolloutfeatures.has()gating checks from 9 backend API endpoints<Feature>component wrappers and feature checks from 7 frontend filestemporary.pyand from thefeature_flagslist inorganization_trace_item_attributes.pySince this flag is fully graduated, all gated code paths are already executing in production. This just removes dead gating code.
Does not touch the separate
preprod-build-distribution-pr-commentsflag.Test plan
pytest -svv --reuse-db tests/sentry/preprod/api/endpoints/— 448 passedCI=true pnpm test static/app/views/preprod/ static/app/views/releases/list/index.spec.tsx— 15 suites, 140 tests passedrg "preprod-frontend-routes"— onlyCHANGESfile (historical changelog)