Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@

### Dependencies

- Bump Cocoa SDK from v9.8.0 to v9.9.0 ([#5956](https://github.com/getsentry/sentry-react-native/pull/5956))
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#990)
- [diff](https://github.com/getsentry/sentry-cocoa/compare/9.8.0...9.9.0)
- Bump Cocoa SDK from v9.8.0 to v9.10.0 ([#5956](https://github.com/getsentry/sentry-react-native/pull/5956), [#5972](https://github.com/getsentry/sentry-react-native/pull/5972))
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#9100)
- [diff](https://github.com/getsentry/sentry-cocoa/compare/9.8.0...9.10.0)

## 8.7.0

Expand Down
2 changes: 1 addition & 1 deletion packages/core/RNSentry.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Pod::Spec.new do |s|
'HEADER_SEARCH_PATHS' => '$(inherited) "${PODS_ROOT}/Sentry/Sources/Sentry" "${PODS_ROOT}/Sentry/Sources/Sentry/include"'
}

s.dependency 'Sentry', '9.9.0'
s.dependency 'Sentry', '9.10.0'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The React Native SDK doesn't expose the new orgId and strictTraceContinuation options from sentry-cocoa v9.10.0, preventing configuration of cross-organization trace continuation behavior.
Severity: MEDIUM

Suggested Fix

Forward the new orgId and strictTraceContinuation options from the React Native layer to the native sentry-cocoa SDK. This involves updating SentrySDKWrapper.m to read these options from the dictionary and pass them to the native Sentry initialization. Alternatively, explicitly document this limitation in the CHANGELOG.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: packages/core/RNSentry.podspec#L55

Potential issue: The update to `sentry-cocoa` v9.10.0 introduces new options, `orgId`
and `strictTraceContinuation`, to manage trace continuation across different
organizations. However, the React Native SDK does not expose these options, so
developers cannot configure them from the JavaScript layer. This can lead to broken
traces in scenarios like self-hosted Sentry instances where the organization ID cannot
be automatically extracted from the DSN, and the application receives requests with
baggage headers from a different organization. The native SDK will detect a mismatch and
break the trace, with no way for the developer to override this behavior.

Did we get this right? 👍 / 👎 to inform future reviews.

if defined? install_modules_dependencies
# Default React Native dependencies for 0.71 and above (new and legacy architecture)
Expand Down
Loading