Skip to content

Conversation

@vaind
Copy link
Collaborator

@vaind vaind commented Oct 20, 2025

No description provided.

{
[Sentry.SentryEvent]DoProcess([Sentry.SentryEvent] $event_)
{
class EventUpdater : SentryEventProcessor {

Check notice

Code scanning / PSScriptAnalyzer

Ignoring 'TypeNotFound' parse error on type 'SentryEventProcessor'. Check if the specified type is correct. This can also be due the type not being known at parse time due to types imported by 'using' statements. Note

Ignoring 'TypeNotFound' parse error on type 'SentryEventProcessor'. Check if the specified type is correct. This can also be due the type not being known at parse time due to types imported by 'using' statements.
@@ -1,9 +1,7 @@
function Get-CurrentOptions
{
function Get-CurrentOptions {

Check warning

Code scanning / PSScriptAnalyzer

The cmdlet 'Get-CurrentOptions' uses a plural noun. A singular noun should be used instead. Warning

The cmdlet 'Get-CurrentOptions' uses a plural noun. A singular noun should be used instead.
# Wrapper to expose Sentry.Internal.SdkComposer::CreateHttpTransport()
function New-HttpTransport
{
function New-HttpTransport {

Check warning

Code scanning / PSScriptAnalyzer

Function 'New-HttpTransport' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'. Warning

Function 'New-HttpTransport' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'.
@@ -1,5 +1,4 @@
class StackTraceProcessor : SentryEventProcessor
{
class StackTraceProcessor : SentryEventProcessor {

Check notice

Code scanning / PSScriptAnalyzer

Ignoring 'TypeNotFound' parse error on type 'SentryEventProcessor'. Check if the specified type is correct. This can also be due the type not being known at parse time due to types imported by 'using' statements. Note

Ignoring 'TypeNotFound' parse error on type 'SentryEventProcessor'. Check if the specified type is correct. This can also be due the type not being known at parse time due to types imported by 'using' statements.

function Start-Sentry
{
function Start-Sentry {

Check warning

Code scanning / PSScriptAnalyzer

Function 'Start-Sentry' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'. Warning

Function 'Start-Sentry' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'.
@@ -1,5 +1,4 @@
function Start-SentryTransaction
{
function Start-SentryTransaction {

Check warning

Code scanning / PSScriptAnalyzer

Function 'Start-SentryTransaction' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'. Warning

Function 'Start-SentryTransaction' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'.
@@ -1,5 +1,4 @@
function Stop-Sentry
{
function Stop-Sentry {

Check warning

Code scanning / PSScriptAnalyzer

Function 'Stop-Sentry' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'. Warning

Function 'Stop-Sentry' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'.
The formatting PR changed code style (moving opening braces to the same line
as function/control structure declarations), which shifted line numbers in
stack traces. This updates test expectations to match the new line numbers:

- integration.tests.ps1: Updated line numbers for funcA (21→19), funcC (12→11),
  and piped command tests (3→2, 4→3)
- stacktrace.tests.ps1: Updated line numbers for funcB calls (19→16, 18→15,
  17→14, 24→19) and funcA (7→6)
- Updated PreContext expectations to reflect compressed formatting
- Changed quote style from double to single quotes in throwingshort.ps1 references

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@vaind vaind merged commit dad86ee into main Oct 20, 2025
14 checks passed
@vaind vaind deleted the chore/formatting branch October 20, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants