-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(core): Add enableTruncation option to Vercel AI integration
#20195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicohrubec
wants to merge
3
commits into
develop
Choose a base branch
from
nh/vercel-enable-truncation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
17 changes: 17 additions & 0 deletions
17
dev-packages/node-integration-tests/suites/tracing/vercelai/instrument-no-truncation.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import * as Sentry from '@sentry/node'; | ||
| import { loggingTransport } from '@sentry-internal/node-integration-tests'; | ||
|
|
||
| Sentry.init({ | ||
| dsn: 'https://public@dsn.ingest.sentry.io/1337', | ||
| release: '1.0', | ||
| tracesSampleRate: 1.0, | ||
| sendDefaultPii: true, | ||
| transport: loggingTransport, | ||
| integrations: [ | ||
| Sentry.vercelAIIntegration({ | ||
| recordInputs: true, | ||
| recordOutputs: true, | ||
| enableTruncation: false, | ||
| }), | ||
| ], | ||
| }); |
28 changes: 28 additions & 0 deletions
28
dev-packages/node-integration-tests/suites/tracing/vercelai/scenario-no-truncation.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import * as Sentry from '@sentry/node'; | ||
| import { generateText } from 'ai'; | ||
| import { MockLanguageModelV1 } from 'ai/test'; | ||
|
|
||
| async function run() { | ||
| await Sentry.startSpan({ op: 'function', name: 'main' }, async () => { | ||
| // Multiple messages with long content (would normally be truncated and popped to last message only) | ||
| const longContent = 'A'.repeat(50_000); | ||
| await generateText({ | ||
| experimental_telemetry: { isEnabled: true }, | ||
| model: new MockLanguageModelV1({ | ||
| doGenerate: async () => ({ | ||
| rawCall: { rawPrompt: null, rawSettings: {} }, | ||
| finishReason: 'stop', | ||
| usage: { promptTokens: 10, completionTokens: 5 }, | ||
| text: 'Response', | ||
| }), | ||
| }), | ||
| messages: [ | ||
| { role: 'user', content: longContent }, | ||
| { role: 'assistant', content: 'Some reply' }, | ||
| { role: 'user', content: 'Follow-up question' }, | ||
| ], | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| run(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The
enableTruncationoption forvercelAIIntegrationis only implemented for Node.js. On other platforms (Cloudflare, Deno, Vercel Edge), truncation is always enabled and cannot be configured.Severity: MEDIUM
Suggested Fix
To ensure consistent behavior, extend the
vercelAIIntegrationin the Cloudflare, Deno, and Vercel Edge packages to accept and store anoptionsobject, similar to the Node.js implementation. Alternatively, document that theenableTruncationoption is only available for the Node.js SDK.Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicohrubec this is legit, e.g.:
sentry-javascript/packages/cloudflare/src/integrations/tracing/vercelai.ts
Line 16 in f1932c9
Doesn't take any options.