feat(core): Expose rewriteSources top level option #20142
Open
feat(core): Expose rewriteSources top level option #20142
rewriteSources top level option #20142Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Deps
Other
Bug Fixes 🐛Core
Other
Internal Changes 🔧Core
Deps
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
approved these changes
Apr 10, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thanks for adding this!
Just to confirm: We already bumped the plugins to the supported version? And sveltekit uses the interface from core directly?
s1gr1d
approved these changes
Apr 10, 2026
| ? fallbackFilesToDelete | ||
| : undefined, | ||
| rewriteSources: (source: string) => normalizePath(source), | ||
| rewriteSources: sourcemapsOptions.rewriteSources ?? ((source: string) => normalizePath(source)), |
Member
There was a problem hiding this comment.
Super-L: Just because I see the pattern here now:
Suggested change
| rewriteSources: sourcemapsOptions.rewriteSources ?? ((source: string) => normalizePath(source)), | |
| rewriteSources: sourcemapsOptions.rewriteSources ?? normalizePath |
This should have the same outcome
nicohrubec
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewriteSourcesto the baseSourceMapsOptionsinterface so users can customize source path rewriting without theunstable_*escape hatchbundler plugins ref getsentry/sentry-javascript-bundler-plugins#908
closes #20028