Skip to content

feat(node-native): Add support for V8 v14 (Node v25+) #20125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timfish wants to merge 3 commits into
base: develop
Choose a base branch
from
+10 −10
Open

feat(node-native): Add support for V8 v14 (Node v25+) #20125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31861ef
feat(node-native): Add support for V8 v14 (Node v25+)
timfish Apr 8, 2026
762af57
yarn dedupe
timfish Apr 8, 2026
c1769d6
Merge branch 'develop' into timfish/feat/V8-v14-support
timfish Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/node-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"build:tarball": "npm pack"
},
"dependencies": {
"@sentry-internal/node-native-stacktrace": "^0.3.0",
"@sentry-internal/node-native-stacktrace": "^0.4.0",
Copy link
Copy Markdown

@cursor cursor bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No integration or E2E test for new feature

Low Severity

This is a feat PR that adds support for V8 v14 (Node v25+) by bumping @sentry-internal/node-native-stacktrace to ^0.4.0, but the PR does not appear to include any integration or E2E test verifying that the new V8 v14 / Node v25+ support actually works. Per the review rules, feat PRs are expected to include at least one integration or E2E test. Adding a test that exercises the event loop block detection on a supported Node version would help catch regressions.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit c1769d6. Configure here.

Copy link
Copy Markdown
Collaborator Author

@timfish timfish Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sentry-internal/node-native-stacktrace is already tested in Node v25 and once this is merged and released it will also be tested in Electron v38+

"@sentry/core": "10.48.0",
"@sentry/node": "10.48.0"
},
Expand Down
18 changes: 9 additions & 9 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7742,13 +7742,13 @@
detect-libc "^2.0.3"
node-abi "^3.73.0"

"@sentry-internal/node-native-stacktrace@^0.3.0":
version "0.3.0"
resolved "https://registry.yarnpkg.com/@sentry-internal/node-native-stacktrace/-/node-native-stacktrace-0.3.0.tgz#68c80dcf11ee070a3a54406b35d4571952caa793"
integrity sha512-ef0M2y2JDrC/H0AxMJJQInGTdZTlnwa6AAVWR4fMOpJRubkfdH2IZXE/nWU0Nj74oeJLQgdPtS6DeijLJtqq8Q==
"@sentry-internal/node-native-stacktrace@^0.4.0":
version "0.4.0"
resolved "https://registry.yarnpkg.com/@sentry-internal/node-native-stacktrace/-/node-native-stacktrace-0.4.0.tgz#8f6e7a21537373a5623714c14d3350e1bb4602f0"
integrity sha512-cuRBBqnsHOJJqLCii9GvwedzjetsihIarq7TxCjgG88JyF8TZWRMlUBu/OogWhYZVU8uHqAeSvpbzolnmdhdkw==
dependencies:
detect-libc "^2.0.4"
node-abi "^3.73.0"
node-abi "^3.89.0"

"@sentry-internal/rrdom@2.34.0":
version "2.34.0"
Expand Down Expand Up @@ -22993,10 +22993,10 @@ nock@^13.5.5:
json-stringify-safe "^5.0.1"
propagate "^2.0.0"

node-abi@^3.3.0, node-abi@^3.73.0:
version "3.75.0"
resolved "https://registry.yarnpkg.com/node-abi/-/node-abi-3.75.0.tgz#2f929a91a90a0d02b325c43731314802357ed764"
integrity sha512-OhYaY5sDsIka7H7AtijtI9jwGYLyl29eQn/W623DiN/MIv5sUqc4g7BIDThX+gb7di9f6xK02nkp8sdfFWZLTg==
node-abi@^3.3.0, node-abi@^3.73.0, node-abi@^3.89.0:
version "3.89.0"
resolved "https://registry.yarnpkg.com/node-abi/-/node-abi-3.89.0.tgz#eea98bf89d4534743bbbf2defa9f4f9bd3bdccfd"
integrity sha512-6u9UwL0HlAl21+agMN3YAMXcKByMqwGx+pq+P76vii5f7hTPtKDp08/H9py6DY+cfDw7kQNTGEj/rly3IgbNQA==
dependencies:
semver "^7.3.5"

Expand Down
Loading