Skip to content

fix(test): Check notification permission before requesting to fix flaky API 34 tests #5146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
romtsn wants to merge 17 commits into from
Closed

fix(test): Check notification permission before requesting to fix flaky API 34 tests #5146

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d48029b
fix(test): Check notification permission before launching request to …
romtsn Mar 3, 2026
9840af3
changelog
romtsn Mar 3, 2026
2a3bbbe
fix(test): Dismiss ANR dialog in Maestro tests before each flow
romtsn Mar 3, 2026
5146f0a
fix(test): Use IMPORTANCE_HIGH for test notifications
romtsn Mar 3, 2026
f9faaf5
fix(test): Make notification shade swipe more reliable
romtsn Mar 3, 2026
a5b4cde
fix(test): Handle permission dialog and clean up notification shade
romtsn Mar 3, 2026
2ceb4d3
fix(test): Use shorter swipe to open notification shade not quick set…
romtsn Mar 3, 2026
5b867fb
fix(test): Reset shade state between retries and recreate notificatio…
romtsn Mar 4, 2026
2a80310
fix(test): Use IMPORTANCE_DEFAULT to avoid heads-up dismissal
romtsn Mar 4, 2026
4b8afe7
fix(test): Use original swipe values with home reset between retries
romtsn Mar 4, 2026
2702cc7
fix(test): Use half-screen swipe and pressKey:back to reliably open n…
romtsn Mar 4, 2026
89fd3f6
fix(test): Always recreate AVD instead of using cache
romtsn Mar 4, 2026
ed4773b
fix(test): Remove AVD cache step entirely
romtsn Mar 4, 2026
cd5740b
fix(test): Move notification tap inside retry loop to avoid race cond…
romtsn Mar 4, 2026
b500a30
fix(test): Use Process.killProcess instead of am force-stop to preser…
romtsn Mar 4, 2026
bf0cfcf
Format code
getsentry-bot Mar 4, 2026
8816dc1
fix(test): Restore original test flow with killApp and Finish Activity
romtsn Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@
- [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#0131)
- [diff](https://github.com/getsentry/sentry-native/compare/0.12.7...0.13.1)

### Internal

- Check notification permission before launching request to fix flaky API 34 tests ([#5146](https://github.com/getsentry/sentry-java/pull/5146))

## 8.33.0

### Features
Expand Down
10 changes: 9 additions & 1 deletion ...y-uitest-android-critical/src/main/java/io/sentry/uitest/android/critical/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.uitest.android.critical

import android.content.Intent
import android.content.pm.PackageManager
import android.os.Build
import android.os.Bundle
import android.widget.Toast
Expand All @@ -22,6 +23,7 @@ import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp
import androidx.core.content.ContextCompat
import io.sentry.Sentry
import io.sentry.android.core.performance.AppStartMetrics
import io.sentry.uitest.android.critical.NotificationHelper.showNotification
Expand Down Expand Up @@ -82,7 +84,13 @@ class MainActivity : ComponentActivity() {
Button(onClick = { finish() }) { Text("Finish Activity") }
Button(
onClick = {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
if (
Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU &&
ContextCompat.checkSelfPermission(
this@MainActivity,
android.Manifest.permission.POST_NOTIFICATIONS,
) != PackageManager.PERMISSION_GRANTED
) {
requestPermissionLauncher.launch(android.Manifest.permission.POST_NOTIFICATIONS)
} else {
postNotification()
Expand Down
Loading