Skip to content

fix: Trim DSN string before URI parsing #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adinauer merged 7 commits into from
Mar 2, 2026
Merged

fix: Trim DSN string before URI parsing #5113

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
97a19d4
fix: Trim DSN string before URI parsing
adinauer Feb 23, 2026
26c1195
docs: Add changelog entry for DSN trimming fix
adinauer Feb 23, 2026
816c849
also trim on SentryOptions.setDsn
adinauer Feb 26, 2026
e20e757
Merge branch 'main' into fix/trim-dsn-whitespace
adinauer Mar 2, 2026
91ec618
fix: Throw clear error when DSN is empty
adinauer Mar 2, 2026
c541368
Format code
getsentry-bot Mar 2, 2026
1017d73
ci: retrigger checks
adinauer Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Fixes

- Trim DSN string before parsing to avoid `URISyntaxException` caused by trailing whitespace ([#5113](https://github.com/getsentry/sentry-java/pull/5113))

## 8.33.0

### Features
Expand Down
4 changes: 2 additions & 2 deletions sentry/src/main/java/io/sentry/Dsn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ URI getSentryUri() {

Dsn(@Nullable String dsn) throws IllegalArgumentException {
try {
Objects.requireNonNull(dsn, "The DSN is required.");
final URI uri = new URI(dsn).normalize();
final String dsnString = Objects.requireNonNull(dsn, "The DSN is required.").trim();
Comment thread
cursor[bot] marked this conversation as resolved.
final URI uri = new URI(dsnString).normalize();
Comment thread
cursor[bot] marked this conversation as resolved.
final String scheme = uri.getScheme();
if (!("http".equalsIgnoreCase(scheme) || "https".equalsIgnoreCase(scheme))) {
throw new IllegalArgumentException("Invalid DSN scheme: " + scheme);
Expand Down
6 changes: 6 additions & 0 deletions sentry/src/test/java/io/sentry/DsnTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@ class DsnTest {
assertEquals("http://host/api/id", dsn.sentryUri.toURL().toString())
}

@Test
fun `dsn parsed with leading and trailing whitespace`() {
val dsn = Dsn(" https://key@host/id ")
assertEquals("https://host/api/id", dsn.sentryUri.toURL().toString())
}

@Test
fun `non http protocols are not accepted`() {
assertFailsWith<IllegalArgumentException> { Dsn("ftp://publicKey:secretKey@host/path/id") }
Expand Down
Loading