Skip to content

fix(replay): Fix crash when root view has no window or is too small #4805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romtsn merged 6 commits into from
Oct 20, 2025
Merged

fix(replay): Fix crash when root view has no window or is too small #4805

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
28a1003
fix(replay): Fix crash when root view has no window or is too small
romtsn Oct 13, 2025
6ed6982
Changelog
romtsn Oct 13, 2025
827d950
move the null check under if(added)
romtsn Oct 13, 2025
e0dc6b2
revert
romtsn Oct 13, 2025
57f3406
revert
romtsn Oct 13, 2025
649c6db
Merge branch 'main' into rz/fix/no-window-root-views
romtsn Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

- Use logger from options for JVM profiler ([#4771](https://github.com/getsentry/sentry-java/pull/4771))
- Session Replay: Avoid deadlock when pausing replay if no connection ([#4788](https://github.com/getsentry/sentry-java/pull/4788))
- Session Replay: Fix capturing roots with no windows ([#4805](https://github.com/getsentry/sentry-java/pull/4805))
- Session Replay: Fix `java.lang.IllegalArgumentException: width and height must be > 0` ([#4805](https://github.com/getsentry/sentry-java/pull/4805))

### Miscellaneous

Expand Down
2 changes: 1 addition & 1 deletion sentry-android-replay/src/main/java/io/sentry/android/replay/ScreenshotRecorder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ public data class ScreenshotRecorderConfig(
private fun Int.adjustToBlockSize(): Int {
val remainder = this % 16
return if (remainder <= 8) {
this - remainder
maxOf(16, this - remainder)
} else {
this + (16 - remainder)
}
Expand Down
5 changes: 5 additions & 0 deletions sentry-android-replay/src/main/java/io/sentry/android/replay/WindowRecorder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ internal class WindowRecorder(
override fun onRootViewsChanged(root: View, added: Boolean) {
rootViewsLock.acquire().use {
if (added) {
if (root.phoneWindow == null) {
Comment thread
romtsn marked this conversation as resolved.
options.logger.log(WARNING, "Root view does not have a phone window, skipping.")
return
}

rootViews.add(WeakReference(root))
capturer?.recorder?.bind(root)
determineWindowSize(root)
Expand Down
Loading