Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Fixes

- Fix Android profile chunk envelope type ([#4366](https://github.com/getsentry/sentry-java/pull/4366))
Comment thread
stefanosiano marked this conversation as resolved.
Outdated

## 8.11.0

### Features
Expand Down
2 changes: 1 addition & 1 deletion sentry/src/main/java/io/sentry/SentryItemType.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public enum SentryItemType implements JsonSerializable {
Attachment("attachment"),
Transaction("transaction"),
Profile("profile"),
ProfileChunk("profile_chunk_ui"),
ProfileChunk("profile_chunk"),
ClientReport("client_report"),
ReplayEvent("replay_event"),
ReplayRecording("replay_recording"),
Expand Down
5 changes: 4 additions & 1 deletion sentry/src/main/java/io/sentry/transport/RateLimiter.java
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,10 @@ private boolean isRetryAfter(final @NotNull String itemType) {
return DataCategory.Attachment;
case "profile":
return DataCategory.Profile;
case "profile_chunk_ui":
// When we send a profile chunk, we have to check for profile_chunk_ui rate limiting,
// because that's what relay returns to rate limit Android. When (if) we will implement JVM
// profiling we will have to check both rate limits.
case "profile_chunk":
return DataCategory.ProfileChunkUi;
case "transaction":
return DataCategory.Transaction;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class SentryItemTypeSerializationTest {
assertEquals(serialize(SentryItemType.Attachment), json("attachment"))
assertEquals(serialize(SentryItemType.Transaction), json("transaction"))
assertEquals(serialize(SentryItemType.Profile), json("profile"))
assertEquals(serialize(SentryItemType.ProfileChunk), json("profile_chunk"))
assertEquals(serialize(SentryItemType.ClientReport), json("client_report"))
assertEquals(serialize(SentryItemType.ReplayEvent), json("replay_event"))
assertEquals(serialize(SentryItemType.ReplayRecording), json("replay_recording"))
Expand All @@ -41,6 +42,7 @@ class SentryItemTypeSerializationTest {
assertEquals(deserialize(json("attachment")), SentryItemType.Attachment)
assertEquals(deserialize(json("transaction")), SentryItemType.Transaction)
assertEquals(deserialize(json("profile")), SentryItemType.Profile)
assertEquals(deserialize(json("profile_chunk")), SentryItemType.ProfileChunk)
assertEquals(deserialize(json("client_report")), SentryItemType.ClientReport)
assertEquals(deserialize(json("replay_event")), SentryItemType.ReplayEvent)
assertEquals(deserialize(json("replay_recording")), SentryItemType.ReplayRecording)
Expand Down