Skip to content

chore(deps): update Native SDK to v0.8.3#4298

Merged
markushi merged 5 commits intomainfrom
deps/scripts/update-sentry-native-ndk.sh/0.8.3
Apr 1, 2025
Merged

chore(deps): update Native SDK to v0.8.3#4298
markushi merged 5 commits intomainfrom
deps/scripts/update-sentry-native-ndk.sh/0.8.3

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Bumps scripts/update-sentry-native-ndk.sh from 0.8.2 to 0.8.3.

Auto-generated by a dependency updater.

Changelog

0.8.3

Features:

  • Add option to attach screenshots on Windows to fatal error events. (#1170, crashpad#123)
  • Add an option for Crashpad on Linux to delay application shutdown until the upload of the crash report in the crashpad_handler is complete. This is useful for deployment in Docker or systemd, where the life cycle of additional processes is bound by the application life cycle. (#1153, crashpad#121)
  • Expose traces_sample_rate option for synchronization with Android SDK. (#1176)

Thank you:

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Mar 29, 2025
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-sentry-native-ndk.sh/0.8.3 branch from b95a863 to acb0847 Compare March 29, 2025 03:12
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-sentry-native-ndk.sh/0.8.3 branch from acb0847 to b588d87 Compare March 31, 2025 07:22
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-sentry-native-ndk.sh/0.8.3 branch from b588d87 to b71cc19 Compare March 31, 2025 07:46
…ub.com:getsentry/sentry-java into deps/scripts/update-sentry-native-ndk.sh/0.8.3
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Mar 31, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 450.63 ms 511.54 ms 60.91 ms
Size 1.58 MiB 2.08 MiB 505.36 KiB

Previous results on branch: deps/scripts/update-sentry-native-ndk.sh/0.8.3

Startup times

Revision Plain With Sentry Diff
6a66b0b 404.02 ms 444.63 ms 40.61 ms

App size

Revision Plain With Sentry Diff
6a66b0b 1.58 MiB 2.08 MiB 505.36 KiB

@markushi markushi requested a review from JoshuaMoelans March 31, 2025 08:23
Copy link
Copy Markdown
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoshuaMoelans
Copy link
Copy Markdown
Member

I think this PR can close out getsentry/sentry-native#1167 . Maybe we do want to add an integration test that checks whether a trace really gets out of the NDK.

Copy link
Copy Markdown
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming null should be 0.0 in native SDK.

@markushi
Copy link
Copy Markdown
Member

markushi commented Apr 1, 2025

LGTM assuming null should be 0.0 in native SDK.

Yes that should be fine, as there's no notion of "disabling tracing" - it's all manual APIs anyway.

@markushi markushi requested a review from lcian as a code owner April 1, 2025 07:54
@markushi markushi enabled auto-merge (squash) April 1, 2025 07:54
@markushi markushi merged commit 0d0e1d3 into main Apr 1, 2025
33 checks passed
@markushi markushi deleted the deps/scripts/update-sentry-native-ndk.sh/0.8.3 branch April 1, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants