[skill-drift] fix(multi-sdk): update 4 skills for recent SDK changes#95
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
[skill-drift] fix(multi-sdk): update 4 skills for recent SDK changes#95github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
…or recent SDK changes - sentry-cocoa-sdk: add strictTraceContinuation and orgId config options (getsentry/sentry-cocoa#7705) - sentry-php-sdk: add metric_flush_threshold config option for auto-flushing metrics (getsentry/sentry-php#2059) - sentry-react-native-sdk: add attachAllThreads iOS option and Sentry.appLoaded() API (getsentry/sentry-react-native#5960, #5940) - sentry-react-sdk: export sentryOnError for react-router v7 onError handler (getsentry/sentry-javascript#20120) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comment on lines
+459
to
+466
|
|
||
| const router = Sentry.wrapCreateBrowserRouterV7(createBrowserRouter)([ | ||
| { | ||
| path: "/", | ||
| element: <RootLayout />, | ||
| onError: Sentry.sentryOnError, // automatically captures route errors | ||
| children: [...], | ||
| }, |
There was a problem hiding this comment.
Bug: The documentation example for React Router v7 incorrectly uses the onError property on a route object. The correct property is errorElement, causing silent failure of error reporting.
Severity: HIGH
Suggested Fix
Replace the incorrect onError: Sentry.sentryOnError example with the correct pattern using the errorElement property, such as errorElement: <SentryRouteErrorBoundary />. This will align the new example with the established, correct pattern already present in the documentation and ensure routing errors are captured by Sentry.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: skills/sentry-react-sdk/references/tracing.md#L459-L466
Potential issue: The documentation example for React Router v7 error handling suggests
using `onError: Sentry.sentryOnError` on individual route objects. However, `onError` is
not a valid property for route objects in React Router v7; it is only valid on the
`<RouterProvider>` component. The correct property is `errorElement`. This is
contradicted by another example in the same file which correctly uses `errorElement`.
Code following the new, incorrect example will silently fail to capture routing errors,
leading to a complete loss of error visibility for those routes.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK Changes
The following PRs were merged in the last 7 days that affect skill files:
metric_flush_thresholdflag sentry-php#2059 — feat(metrics): addmetric_flush_thresholdflag (feat(metrics): addmetric_flush_thresholdflag sentry-php#2059)attachAllThreadsoption sentry-react-native#5960 — feat(ios): AddattachAllThreadsoption (feat(ios): AddattachAllThreadsoption sentry-react-native#5960)sentryOnErrorsentry-javascript#20120 — feat(react-router): ExportsentryOnError(feat(react-router): ExportsentryOnErrorsentry-javascript#20120)Changes Made
skills/sentry-cocoa-sdk/references/tracing.mdstrictTraceContinuationandorgIdto the Configuration tableskills/sentry-php-sdk/references/metrics.mdmetric_flush_thresholdfor PHP/Laravelmetric_flush_thresholdto the Symfony YAML configuration exampleskills/sentry-react-native-sdk/SKILL.mdattachAllThreads(iOS only) to the Native/Mobile Options tableSentry.appLoaded()" section explaining when and how to call itskills/sentry-react-sdk/references/tracing.mdSentry.sentryOnErroras a simpler alternative toSentryRouteErrorBoundaryin the React Router v7 error handling sectionVerified Against
#7705)#2059)#5960,#5940)#20120)Note
🔒 Integrity filter blocked 21 items
The following items were blocked because they don't meet the GitHub integrity level.
list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: