-
-
Notifications
You must be signed in to change notification settings - Fork 230
build(deps): bump dotnet-sdk from 10.0.102 to 10.0.201 #5029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jamescrosswell
merged 9 commits into
main
from
dependabot/dotnet_sdk/dotnet-sdk-10.0.201
Mar 26, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
584a57f
build(deps): bump dotnet-sdk from 10.0.102 to 10.0.201
dependabot[bot] 04f4f0f
Merge remote-tracking branch 'origin/main' into dependabot/dotnet_sdk…
jamescrosswell d104890
Workaround regression in .net 10.0.201
jamescrosswell 309b7ef
review feedback
jamescrosswell 2c0b75b
.
jamescrosswell 67ebac1
Bump runner for msbuild tests to windows-2025-vs2026
jamescrosswell a08828e
Added missing mapping
jamescrosswell fe87919
.
jamescrosswell 4fbbe56
Remove redundant comments - tests now pass on Win Arm64
jamescrosswell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| { | ||
| "omnisharp.useModernNet": true, | ||
| "dotnet.defaultSolution": "Sentry.slnx" | ||
| "dotnet.defaultSolution": "Sentry.slnx", | ||
| "java.configuration.updateBuildConfiguration": "interactive" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,12 +24,7 @@ public void GetRuntime_AllProperties() | |
| { | ||
| Assert.Equal(".NET Framework", actual.Name); | ||
| actual.FrameworkInstallation.Should().NotBeNull("FrameworkInstallation is null"); | ||
| // TODO: Windows ARM64 broke in CI... the timing wasn't very good (same day .NET 10 was announced) and I | ||
| // don't have a Windows ARM64 device to test on. Will need to debug in CI when we've released V6. | ||
| if (RuntimeInformation.ProcessArchitecture != Architecture.Arm64) | ||
| { | ||
| actual.FrameworkInstallation.Version.Should().NotBeNull("FrameworkInstallation.Version is null"); | ||
| } | ||
| actual.FrameworkInstallation.Version.Should().NotBeNull("FrameworkInstallation.Version is null"); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was fixing this for Win64 anyway, so we can finally remove the todo from the v6 release. |
||
| } | ||
| else | ||
| { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated Java VS Code setting accidentally committed
Low Severity
The
java.configuration.updateBuildConfigurationsetting is a Java extension preference that has no relation to this .NET SDK bump PR. This appears to be a local VS Code configuration change that was unintentionally staged and committed alongside the actual changes. It adds noise to the shared workspace settings for a project that has no Java components.