Skip to content

feat(elixir): Add propagator, LiveView tracing, and Plug.Telemetry note#17336

Merged
sl0thentr0py merged 1 commit intomasterfrom
neel/elixir-propagator
Apr 14, 2026
Merged

feat(elixir): Add propagator, LiveView tracing, and Plug.Telemetry note#17336
sl0thentr0py merged 1 commit intomasterfrom
neel/elixir-propagator

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

DESCRIBE YOUR PR

Document Sentry.OpenTelemetry.Propagator for distributed tracing via sentry-trace and baggage headers. Add LiveView trace propagation setup using LiveViewPropagator and Plug.LiveViewContext. Include note about OpentelemetryPhoenix requiring Plug.Telemetry in the endpoint.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sentry-docs Ready Ready Preview, Comment Apr 14, 2026 3:35pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
develop-docs Ignored Ignored Preview Apr 14, 2026 3:35pm

Request Review

Comment on lines +65 to +70
config :opentelemetry,
text_map_propagators: [
:trace_context,
:baggage,
Sentry.OpenTelemetry.Propagator
]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The documentation for text_map_propagators suggests a mixed list of atoms and module references, a pattern not confirmed to be supported by the OpenTelemetry Elixir SDK.
Severity: MEDIUM

Suggested Fix

Verify with the OpenTelemetry Elixir SDK source code or official documentation whether mixed-type lists are supported for text_map_propagators. If not, update the documentation to show a supported configuration pattern, which might involve using only atoms or providing a different mechanism for custom propagators.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: docs/platforms/elixir/tracing/index.mdx#L65-L70

Potential issue: The documentation suggests configuring `text_map_propagators` with a
mixed list containing both atoms (e.g., `:trace_context`) and module references (e.g.,
`Sentry.OpenTelemetry.Propagator`). There is no authoritative documentation or source
code evidence from the OpenTelemetry Elixir SDK to confirm that it can parse and handle
such a mixed-type list. If a user implements this configuration, the application could
either crash during initialization or, more subtly, fail to register the custom
propagator, leading to incomplete tracing data in production without any obvious error.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@solnic is this a valid problem?

Document Sentry.OpenTelemetry.Propagator for distributed tracing via
sentry-trace and baggage headers. Add LiveView trace propagation setup
using LiveViewPropagator and Plug.LiveViewContext. Include note about
OpentelemetryPhoenix requiring Plug.Telemetry in the endpoint.

Co-Authored-By: Claude <noreply@anthropic.com>
@sl0thentr0py sl0thentr0py force-pushed the neel/elixir-propagator branch from 7d37524 to 68ede5c Compare April 14, 2026 15:24
@sl0thentr0py sl0thentr0py merged commit 8d82dbe into master Apr 14, 2026
18 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/elixir-propagator branch April 14, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants