feat(elixir): Add propagator, LiveView tracing, and Plug.Telemetry note#17336
Merged
sl0thentr0py merged 1 commit intomasterfrom Apr 14, 2026
Merged
feat(elixir): Add propagator, LiveView tracing, and Plug.Telemetry note#17336sl0thentr0py merged 1 commit intomasterfrom
sl0thentr0py merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Comment on lines
+65
to
+70
| config :opentelemetry, | ||
| text_map_propagators: [ | ||
| :trace_context, | ||
| :baggage, | ||
| Sentry.OpenTelemetry.Propagator | ||
| ] |
There was a problem hiding this comment.
Bug: The documentation for text_map_propagators suggests a mixed list of atoms and module references, a pattern not confirmed to be supported by the OpenTelemetry Elixir SDK.
Severity: MEDIUM
Suggested Fix
Verify with the OpenTelemetry Elixir SDK source code or official documentation whether mixed-type lists are supported for text_map_propagators. If not, update the documentation to show a supported configuration pattern, which might involve using only atoms or providing a different mechanism for custom propagators.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs/platforms/elixir/tracing/index.mdx#L65-L70
Potential issue: The documentation suggests configuring `text_map_propagators` with a
mixed list containing both atoms (e.g., `:trace_context`) and module references (e.g.,
`Sentry.OpenTelemetry.Propagator`). There is no authoritative documentation or source
code evidence from the OpenTelemetry Elixir SDK to confirm that it can parse and handle
such a mixed-type list. If a user implements this configuration, the application could
either crash during initialization or, more subtly, fail to register the custom
propagator, leading to incomplete tracing data in production without any obvious error.
Did we get this right? 👍 / 👎 to inform future reviews.
solnic
approved these changes
Apr 14, 2026
Document Sentry.OpenTelemetry.Propagator for distributed tracing via sentry-trace and baggage headers. Add LiveView trace propagation setup using LiveViewPropagator and Plug.LiveViewContext. Include note about OpentelemetryPhoenix requiring Plug.Telemetry in the endpoint. Co-Authored-By: Claude <noreply@anthropic.com>
7d37524 to
68ede5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Document Sentry.OpenTelemetry.Propagator for distributed tracing via sentry-trace and baggage headers. Add LiveView trace propagation setup using LiveViewPropagator and Plug.LiveViewContext. Include note about OpentelemetryPhoenix requiring Plug.Telemetry in the endpoint.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: