feat(attributes): Add browser.connection.rtt attribute#237
Open
feat(attributes): Add browser.connection.rtt attribute#237
browser.connection.rtt attribute#237Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛Attributes
Other
Internal Changes 🔧Attributes
Deps Dev
Repo
Other
Other
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our JS SDK records a
connection.rttmeasurement, measuring the estimated request RTT based on the current connection quality. This is not really a performance indicator of made requests, but rather just an estimate how fast a request/response cycle will likely be handled. Anyway, we record this on the pageload and navigation spans (not sure about the value tbh but we do).For converting this measurement to an attribute, I for now decided to use the
browsernamespace due to this value being a coarse estimation. We could use thenetworknamespace and add something likenetwork.connection.rtt. Just not sure if we want these estimations connected to the more general attribute. But tbh, LOGAF-L, so whatever reviewers prefer.