feat(attributes): Add core web web vital value attributes#229
Open
feat(attributes): Add core web web vital value attributes#229
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
cleptric
approved these changes
Jan 22, 2026
Lms24
force-pushed
the
lms/feat-web-vital-attributes
branch
from
fcc2171 to
c248972
Compare
Lms24
changed the title
Lms24
force-pushed
the
lms/feat-web-vital-attributes
branch
from
c0bd592 to
c248972
Compare
Lms24
force-pushed
the
lms/feat-web-vital-attributes
branch
from
c248972 to
18ea0e6
Compare
lcian
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds attributes for Core Web Vitals measurements:
browser.web_vital.cls.valuebrowser.web_vital.lcp.valuebrowser.web_vital.inp.valueThese new attributes are inspired by OTel, who use
browser.web_vital.(lcp|inp|fid|cls)span event names for recording web vitals. I still marked"is_in_otel": falsebecause they are not attributes in OTel but span events. But open to change this if reviewers prefertruehere.For backward compatibility, the original shorthand attributes (
cls,lcp,inp) are also added but marked as deprecated with references to their new replacements.