feat(feedback): add runtime shake gesture toggle API#7737
Closed
feat(feedback): add runtime shake gesture toggle API#7737
Conversation
Add SentrySDK.feedback.enableShakeGesture() and disableShakeGesture() for dynamic control at runtime.
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Documentation 📚
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Remove existing shake observer before adding in enableShakeGesture() to prevent duplicate notifications on repeated calls or when useShakeGesture was set at init. Add test-only cooldown reset to eliminate 1.1s sleep in re-enable test.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7737 +/- ##
=============================================
- Coverage 85.375% 85.047% -0.328%
=============================================
Files 487 487
Lines 28985 28999 +14
Branches 12551 12549 -2
=============================================
- Hits 24746 24663 -83
- Misses 4193 4288 +95
- Partials 46 48 +2
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Author
|
@sentry review |
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
Closing this as we decided not to proceed with exposing this API / cc @christophaigner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add
SentrySDK.feedback.enableShakeGesture()andSentrySDK.feedback.disableShakeGesture()for dynamic control of shake-to-report at runtime, similar to the React Native API.This allows users to enable/disable shake gesture on specific screens or app contexts without restarting the SDK.
💡 Motivation and Context
The existing
useShakeGestureconfig is set at SDK init time and can't be changed at runtime. Users need per-screen control (e.g., enable in settings, disable in checkout).Builds on #7579 which added the initial shake gesture detection.
💚 How did you test it?
make format,make analyze,make build-ios, all pass📝 Checklist
sendDefaultPIIis enabled.