-
-
Notifications
You must be signed in to change notification settings - Fork 375
fix: Fix incorrect variable assignment for 'sampled' key #7120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In SentryTraceContext, the 'sampled' key was incorrectly using _sampleRate.
|
@xjshi thanks for the fix! Would you mind adding a test for this? Or would like me to push the required tests for this? (to this doesn't happen again) |
❌ 2 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
|
@itaybre Test added. It verifies all fields in the dictionary returned by the |
|
@sentry review |
|
Updating the branch, so checks can pass 🟢 |
itaybre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Merging this PR, I will open a different one with the changelog changes |
In SentryTraceContext, the 'sampled' key was incorrectly using _sampleRate.
📜 Description
In SentryTraceContext.m, the 'sampled' key was incorrectly using _sampleRate. This resulted in malformed trace contexts being sent to Sentry, potentially breaking sampling decisions in distributed tracing.