fix(r8-tests): Align retrace no‑position handling with R8 semantics#81
Closed
romtsn wants to merge 2 commits intorz/feat/r8-tests-method-overloadingfrom
Closed
fix(r8-tests): Align retrace no‑position handling with R8 semantics#81romtsn wants to merge 2 commits intorz/feat/r8-tests-method-overloadingfrom
romtsn wants to merge 2 commits intorz/feat/r8-tests-method-overloadingfrom
Conversation
loewenheim
reviewed
Jan 30, 2026
Contributor
loewenheim
left a comment
There was a problem hiding this comment.
Some of the fields/parameters could use documentation about what they are intended to do.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rz/feat/r8-tests-method-overloading #81 +/- ##
======================================================================
Coverage ? 84.29%
======================================================================
Files ? 9
Lines ? 3763
Branches ? 0
======================================================================
Hits ? 3172
Misses ? 591
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
closing this one for now, as we've adjusted test expectations, see 4c17e66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen in some of our customers' mappings, frames can come without a filename, so we need handle those cases as well: