Skip to content

fix(r8-tests): Align retrace no‑position handling with R8 semantics#81

Closed
romtsn wants to merge 2 commits intorz/feat/r8-tests-method-overloadingfrom
rz/fix/r8-tests-method-overloading
Closed

fix(r8-tests): Align retrace no‑position handling with R8 semantics#81
romtsn wants to merge 2 commits intorz/feat/r8-tests-method-overloadingfrom
rz/fix/r8-tests-method-overloading

Conversation

@romtsn
Copy link
Copy Markdown
Member

@romtsn romtsn commented Jan 30, 2026

As seen in some of our customers' mappings, frames can come without a filename, so we need handle those cases as well:

 at com.mycompany.ui.DynamicFlowScreenKt.DynamicFlowScreen$lambda$1(:73)
...
 at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(:398)

@romtsn romtsn requested a review from loewenheim January 30, 2026 14:21
Copy link
Copy Markdown
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the fields/parameters could use documentation about what they are intended to do.

Comment thread src/cache/mod.rs Outdated
@romtsn romtsn changed the title fix(r8-tests): Fix overload lookup to include line-ranged candidates without file fix(r8-tests): Align retrace no‑position handling with R8 semantics Feb 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 28.57143% with 50 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rz/feat/r8-tests-method-overloading@94d628e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/cache/mod.rs 23.25% 33 Missing ⚠️
src/mapper.rs 37.03% 17 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##             rz/feat/r8-tests-method-overloading      #81   +/-   ##
======================================================================
  Coverage                                       ?   84.29%           
======================================================================
  Files                                          ?        9           
  Lines                                          ?     3763           
  Branches                                       ?        0           
======================================================================
  Hits                                           ?     3172           
  Misses                                         ?      591           
  Partials                                       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romtsn romtsn requested a review from loewenheim February 3, 2026 17:11
@romtsn
Copy link
Copy Markdown
Member Author

romtsn commented Feb 5, 2026

closing this one for now, as we've adjusted test expectations, see 4c17e66

@romtsn romtsn closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants