Skip to content

fix(r8-tests): Fix retrace line handling for edge cases#80

Closed
romtsn wants to merge 4 commits intorz/feat/r8-tests-line-number-handlingfrom
rz/fix/r8-tests-line-number-handling
Closed

fix(r8-tests): Fix retrace line handling for edge cases#80
romtsn wants to merge 4 commits intorz/feat/r8-tests-line-number-handlingfrom
rz/fix/r8-tests-line-number-handling

Conversation

@romtsn
Copy link
Copy Markdown
Member

@romtsn romtsn commented Jan 29, 2026

  • Preserve original line info for no‑range mappings and refine no‑line/line‑range selection to match R8 behavior
  • Make stacktrace parsing more permissive for colon filenames and empty line suffixes
  • Align mapper/cache behavior (queueing + selection) and update line‑number fixtures / edge‑case tests and notes
  • Bump PRGCACHE version because we need to invalidate caches since we use a new sentinel value (u32::MAX) to distinguish from an explicit 0:0 minified range

@romtsn romtsn requested a review from loewenheim January 29, 2026 12:52
Copy link
Copy Markdown
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't studied the logic in detail yet, but does using u32::MAX as a placeholder require invalidate old caches?

@romtsn
Copy link
Copy Markdown
Member Author

romtsn commented Jan 30, 2026

does using u32::MAX as a placeholder require invalidate old caches?

I believe so, so we probably have to bump the cache version, good point!

@romtsn romtsn requested a review from loewenheim February 3, 2026 17:17
@romtsn
Copy link
Copy Markdown
Member Author

romtsn commented Feb 3, 2026

Updated to also Bump proguard cache version

@romtsn
Copy link
Copy Markdown
Member Author

romtsn commented Feb 9, 2026

closing in favour of a chain of PRs (#82 - #87)

@romtsn romtsn closed this Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants