feat(r8-tests): Add R8 ambiguous tests by romtsn · Pull Request #71 · getsentry/rust-proguard

romtsn · 2025-12-19T16:24:27Z

Part of #40

There are failing tests in this PR that need fixes in the mapper/cache itself, so I will open a follow-up PR that targets this branch.

R8 Retrace Test Coverage

Inlining (13 tests) - inline frames, line numbers, source files, rewriteFrame rules
Ambiguous Methods (21 tests) - multiple methods → same obfuscated name, alternatives
Outlines (4 tests) - outline callsites, nested outlines, inline-in-outline
Synthetic/Lambda (3 tests) - lambda methods, synthetic bridges
Source File Edge Cases (7 tests) - colons, unicode, multiple dots, synthesized names
Line Number Handling (10 tests) - spans, preambles, invalid ranges, missing lines
Exception Handling (6 tests) - obfuscated exceptions, suppressed, circular refs
Method Overloading (4 tests) - overloads with/without ranges
Special Formats (4 tests) - Java 9+ modules, logcat format, auto-detect

romtsn · 2025-12-23T13:24:09Z

@loewenheim I've updated tests to match the exact expected output from retrace, and have a couple of questions that we need to make a decision on, hence re-requested a review

loewenheim · 2026-01-12T08:23:02Z

I would honestly not support these alternative stacktraces for now—I don't understand how they work and can't see how we would consume them.

- Improved stacktrace parsing to handle frames that omit a line number (e.g. (Unknown), (Unknown Source), (Foo.java)) by treating them as line 0 so they can be retraced. - Enhanced retracing behavior for unknown-line frames: - Prefer base (no-line) mappings when the stacktrace frame has no line info. - Still prefer line-specific mappings when a concrete line is present (skipping 0:0 / base entries appropriately). - Added best-effort class remapping even when the method name isn’t mapped (replicates symbolicator behaviour -- we can probably ditch it from symbolicator once this is shipped) - Aligned cache behavior with mapper behavior: - Cache serialization no longer drops base/no-line member mappings (instead, we check it during remapping) - Cache remapping now mirrors mapper rules for unknown-line frames (including deduplication) The tests in #71 should pass with this PR

feat(r8-tests): Add R8 ambiguous tests

216c5eb

romtsn requested a review from loewenheim December 19, 2025 16:26

loewenheim approved these changes Dec 19, 2025

View reviewed changes

Update tests

7ae46d0

romtsn mentioned this pull request Dec 23, 2025

fix(r8-tests): Correctly handle no-line mappings #72

Merged

Change expected of test_ambiguous_missing_line_stacktrace

1deef0a

romtsn commented Dec 23, 2025

View reviewed changes

Comment thread tests/r8-ambiguous.rs

romtsn commented Dec 23, 2025

View reviewed changes

Comment thread tests/r8-ambiguous.rs

romtsn commented Dec 23, 2025

View reviewed changes

Comment thread tests/r8-ambiguous.rs

romtsn requested a review from loewenheim December 23, 2025 13:23

Add MD file explaining failures

701208a