fix(r8): Synthesize file name for foreign members and classes without sourceFile annotation#70
Merged
romtsn merged 4 commits intorz/feat/r8-tests-inlinefrom Dec 18, 2025
Conversation
…sourceFile annotation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+318
to
328
| let file_name_offset = class_info | ||
| .and_then(|ci| ci.source_file) | ||
| .map_or(u32::MAX, |s| string_table.insert(s) as u32); | ||
| let class = ClassInProgress { | ||
| class: Class { | ||
| original_name_offset, | ||
| obfuscated_name_offset, | ||
| file_name_offset, | ||
| is_synthesized: is_synthesized as u8, | ||
| ..Default::default() | ||
| }, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
I don't think anything changed we just started using/supplying file_name_offset
loewenheim
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the test cases in #69 it seems r8-retrace always synthesizes filenames from class names, so this PR attempts to do the same for mapper/cache and also updates existing test cases to match the new behavior (the tests in
r8-inline.rsshould be passing with this change)