Skip to content

feat(r8): Support rewriteFrames annotation in ProguardMapper#66

Merged
romtsn merged 12 commits intomasterfrom
rz/feat/rewrite-frames-support
Dec 17, 2025
Merged

feat(r8): Support rewriteFrames annotation in ProguardMapper#66
romtsn merged 12 commits intomasterfrom
rz/feat/rewrite-frames-support

Conversation

@romtsn
Copy link
Copy Markdown
Member

@romtsn romtsn commented Dec 1, 2025

Part of #63

  • Added new header parsing
  • Adapted ProguardMapper to ccollect the frames and then apply the rewrite rules on the entire vector
  • Added parsing of the exception for remap_stacktrace which accepts a plain string -- we need that info to decide whether we remove inner frames or not

See linked issue for more details.

@romtsn romtsn requested a review from loewenheim December 1, 2025 12:21
Comment thread src/builder.rs Outdated
Comment thread src/mapper.rs Outdated
Comment thread src/mapper.rs Outdated
Copy link
Copy Markdown
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by mistake

Comment thread src/mapper.rs
@romtsn romtsn requested a review from loewenheim December 4, 2025 09:44
Copy link
Copy Markdown
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor improvement that can be made, otherwise this looks good.

Comment thread src/mapper.rs Outdated
Comment thread src/mapper.rs
@romtsn
Copy link
Copy Markdown
Member Author

romtsn commented Dec 9, 2025

@loewenheim As discussed internally I implemented skipping the line completely if a rewrite rule cleared up all frames and also added a test to verify that: bb565b7

@loewenheim
Copy link
Copy Markdown
Contributor

From my perspective this is good to merge

@romtsn romtsn merged commit 08f5382 into master Dec 17, 2025
7 checks passed
@romtsn romtsn deleted the rz/feat/rewrite-frames-support branch December 17, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants