Skip to content

Refactor GoCD Slack feed handler to handle failures gracefully#776

Open
IanWoodard wants to merge 1 commit intomainfrom
iw/all-settled
Open

Refactor GoCD Slack feed handler to handle failures gracefully#776
IanWoodard wants to merge 1 commit intomainfrom
iw/all-settled

Conversation

@IanWoodard
Copy link
Copy Markdown
Contributor

This aims to better handle potential failures, especially now that we have quite a few deploy feeds.

@IanWoodard IanWoodard requested a review from hubertdeng123 April 3, 2024 15:09
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2024

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.25%. Comparing base (c89c067) to head (d003021).
⚠️ Report is 130 commits behind head on main.

Files with missing lines Patch % Lines
src/brain/gocdSlackFeeds/index.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   86.26%   86.25%   -0.02%     
==========================================
  Files         116      116              
  Lines        3306     3310       +4     
  Branches      664      665       +1     
==========================================
+ Hits         2852     2855       +3     
- Misses        440      441       +1     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants