feat(commands): add buildRouteMap wrapper with standard subcommand aliases#690
Merged
feat(commands): add buildRouteMap wrapper with standard subcommand aliases#690
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Contributor
Codecov Results 📊✅ 134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1488 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 95.44% 95.43% -0.01%
==========================================
Files 223 224 +1
Lines 32511 32538 +27
Branches 0 0 —
==========================================
+ Hits 31027 31050 +23
- Misses 1484 1488 +4
- Partials 0 0 —Generated by Codecov Action |
BYK
force-pushed
the
feat/ls-alias-for-list-commands
branch
from
f944e25 to
a17e0ef
Compare
BYK
changed the title
ls as alias for list across all route groups
…iases Introduce `src/lib/route-map.ts` as the single entry point for building route maps — analogous to how `src/lib/command.ts` wraps Stricli's `buildCommand`. The wrapper auto-injects standard aliases based on which route keys exist: list → ls view → show delete → remove, rm create → new All 16 command group index.ts files and app.ts now import from the wrapper instead of @stricli/core directly. Manual aliases that are covered by the standard set have been removed. Also update `getSubcommandsForRoute()` in list-command.ts to collect subcommand aliases so plural+alias combos like `sentry issues ls` are properly intercepted.
BYK
force-pushed
the
feat/ls-alias-for-list-commands
branch
from
67c9b17 to
d4fb1cd
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
BYK
force-pushed
the
feat/ls-alias-for-list-commands
branch
from
8b8d1fb to
7c55b2f
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7c55b2f. Configure here.
Stricli always provides aliases at runtime (empty array when none), but type it as optional and use ?? [] for defensive safety per Seer and BugBot review feedback.
BYK
force-pushed
the
feat/ls-alias-for-list-commands
branch
from
7c55b2f to
a9c4c37
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/lib/route-map.tsas the single entry point for building Stricli route maps — analogous to howsrc/lib/command.tswrapsbuildCommandlist→ls,view→show,delete→remove/rm,create→newindex.tsfiles andapp.tsto import from the wrapper instead of@stricli/coredirectlygetSubcommandsForRoute()inlist-command.tsto collect subcommand aliases so plural+alias combos likesentry issues lsare properly intercepted