Skip to content

fix(init): generate spinner messages from payload params instead of server detail#655

Merged
MathurAditya724 merged 3 commits intomainfrom
feat/init-describe-local-ops
Apr 6, 2026
Merged

fix(init): generate spinner messages from payload params instead of server detail#655
MathurAditya724 merged 3 commits intomainfrom
feat/init-describe-local-ops

Conversation

@MathurAditya724
Copy link
Copy Markdown
Member

Summary

  • Replace server-provided detail spinner messages with CLI-generated messages derived from actual payload params (paths, commands, patches, etc.)
  • The server detail string could show misleading file names (e.g. JS config files when running in a Python project). The CLI now always shows truthful info about which files are being read, written, or checked.
  • Add describeLocalOp() function covering all 6 operation types: read-files, file-exists-batch, apply-patchset, run-commands, list-dir, create-sentry-project

Examples

Operation Before (server detail) After (CLI-generated)
read-files "Reading next.config.js..." "Reading settings.py..."
apply-patchset (1 file) "Applying sentry config..." "Creating sentry.py..."
apply-patchset (N files) "Applying changes..." "Applying 3 file changes (2 created, 1 modified)..."
run-commands "npm install @sentry/nextjs..." "Running pip install sentry-sdk..."

Test plan

  • Updated 3 existing integration tests to verify server detail is ignored
  • Added 12 new unit tests for describeLocalOp covering all operation types and edge cases (empty paths, single/multi file, action breakdowns)
  • All 43 tests in wizard-runner.test.ts pass

…erver detail

The server-provided detail string could show misleading file names
(e.g. JS config files for a Python project). Replace it with
CLI-generated messages derived from the actual payload params so
the user always sees truthful info about which files are being
read, written, or checked.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Bug Fixes 🐛

  • (errors) Separate informational notes from actionable alternatives in ContextError by BYK in #651
  • (init) Generate spinner messages from payload params instead of server detail by MathurAditya724 in #655
  • Fix set-commits --auto, document release workflow pitfalls by BYK in #650

Internal Changes 🔧

  • Regenerate skill files and command docs by github-actions[bot] in eb1b19e7

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Codecov Results 📊

134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 1431 uncovered lines.
❌ Project coverage is 95.52%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    95.54%    95.52%    -0.02%
==========================================
  Files          220       220         —
  Lines        31869     31939       +70
  Branches         0         0         —
==========================================
+ Hits         30446     30508       +62
- Misses        1423      1431        +8
- Partials         0         0         —

Generated by Codecov Action

The server will no longer send detail strings. Remove the field from
all 6 payload type definitions and clean up related JSDoc and tests.
Add optional message field to LocalOpResult so local-ops can surface
user-facing feedback without doing UI work directly. When
create-sentry-project detects a duplicate, the spinner now shows
'Using existing project "slug" in org' instead of silently reusing.
@MathurAditya724 MathurAditya724 marked this pull request as ready for review April 6, 2026 08:02
@MathurAditya724 MathurAditya724 merged commit 915f2bc into main Apr 6, 2026
25 checks passed
@MathurAditya724 MathurAditya724 deleted the feat/init-describe-local-ops branch April 6, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant