fix(dashboard): move untracked-display guard into validateWidgetEnums

The isTrackedDisplay check was only applied in buildReplacement, but
validateWidgetEnums is also called early in both edit and add (before
any widget fetching) with the raw flags. Passing --display text --dataset
spans would still throw there, contradicting the documented behavior that
untracked types (text, wheel, rage_and_dead_clicks, agents_traces_table)
"bypass Sentry's dataset system entirely and have no constraints."

Move the guard into validateWidgetEnums itself so the fix applies to all
callers uniformly. buildReplacement can now call validateWidgetEnums
directly without duplicating the logic.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: betegon

src/commands/dashboard/resolve.ts

@@ -384,12 +384,19 @@ export function validateWidgetEnums(display?: string, dataset?: string): void {
     );
   }
   if (display && dataset) {
-    const supported = DATASET_SUPPORTED_DISPLAY_TYPES[dataset as WidgetType];
-    if (supported && !(supported as readonly string[]).includes(display)) {
-      throw new ValidationError(
-        `The "${dataset}" dataset supports: ${supported.join(", ")}. Got: "${display}".`,
-        "display"
-      );
+    // Untracked display types (text, wheel, rage_and_dead_clicks, agents_traces_table)
+    // bypass Sentry's dataset query system entirely — no dataset constraint applies.
+    const isTrackedDisplay = Object.values(
+      DATASET_SUPPORTED_DISPLAY_TYPES
+    ).some((types) => (types as readonly string[]).includes(display));
+    if (isTrackedDisplay) {
+      const supported = DATASET_SUPPORTED_DISPLAY_TYPES[dataset as WidgetType];
+      if (supported && !(supported as readonly string[]).includes(display)) {
+        throw new ValidationError(
+          `The "${dataset}" dataset supports: ${supported.join(", ")}. Got: "${display}".`,
+          "display"
+        );
+      }
     }
   }
 }

src/commands/dashboard/widget/edit.ts

@@ -13,7 +13,6 @@ import { formatWidgetEdited } from "../../../lib/formatters/human.js";
 import { CommandOutput } from "../../../lib/formatters/output.js";
 import { buildDashboardUrl } from "../../../lib/sentry-urls.js";
 import {
-  DATASET_SUPPORTED_DISPLAY_TYPES,
   type DashboardDetail,
   type DashboardWidget,
   type DashboardWidgetQuery,
@@ -74,7 +73,6 @@ function mergeQueries(
 }
 
 /** Build the replacement widget object by merging flags over existing */
-// biome-ignore lint/complexity/noExcessiveCognitiveComplexity: merging + validating widget flags requires several conditional branches
 function buildReplacement(
   flags: EditFlags,
   existing: DashboardWidget
@@ -98,25 +96,9 @@ function buildReplacement(
   // Re-validate after merging with existing values. validateWidgetEnums only
   // checks the cross-constraint when both args are provided, so it misses
   // e.g. `--dataset preprod-app-size` on a widget that's already `table`.
-  //
-  // Scope: only cross-validate when effectiveDisplay is a tracked type (present in
-  // DATASET_SUPPORTED_DISPLAY_TYPES). Untracked types — text, wheel, rage_and_dead_clicks,
-  // agents_traces_table — bypass Sentry's dataset system entirely and have no constraints.
-  // Validating them against a dataset would always fail, blocking legitimate edits like
-  // changing --dataset on a text widget.
+  // validateWidgetEnums itself skips untracked display types (text, wheel, etc.).
   if (flags.display || flags.dataset) {
-    // Only cross-validate when effectiveDisplay is a tracked type (present in
-    // DATASET_SUPPORTED_DISPLAY_TYPES). Untracked types — text, wheel,
-    // rage_and_dead_clicks, agents_traces_table — bypass Sentry's dataset system
-    // entirely, so any dataset is valid with them regardless of which flag triggered this.
-    const isTrackedDisplay = Object.values(
-      DATASET_SUPPORTED_DISPLAY_TYPES
-    ).some((types) =>
-      (types as readonly string[]).includes(effectiveDisplay ?? "")
-    );
-    if (isTrackedDisplay) {
-      validateWidgetEnums(effectiveDisplay, effectiveDataset);
-    }
+    validateWidgetEnums(effectiveDisplay, effectiveDataset);
   }
 
   const raw: Record<string, unknown> = {