fix(dashboard): validate only tracked display types in buildReplacement

The previous fix used `if (flags.display || isTrackedDisplay)` which still
triggered validateWidgetEnums when the user passed --display with an untracked
type (e.g. text), causing a spurious ValidationError. Simplify to just
`if (isTrackedDisplay)` — untracked display types carry no dataset constraints
regardless of how the flag was set.

Also adds a test covering --display text to prevent regression.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: betegon

src/commands/dashboard/widget/edit.ts

@@ -105,12 +105,16 @@ function buildReplacement(
   // Validating them against a dataset would always fail, blocking legitimate edits like
   // changing --dataset on a text widget.
   if (flags.display || flags.dataset) {
+    // Only cross-validate when effectiveDisplay is a tracked type (present in
+    // DATASET_SUPPORTED_DISPLAY_TYPES). Untracked types — text, wheel,
+    // rage_and_dead_clicks, agents_traces_table — bypass Sentry's dataset system
+    // entirely, so any dataset is valid with them regardless of which flag triggered this.
     const isTrackedDisplay = Object.values(
       DATASET_SUPPORTED_DISPLAY_TYPES
     ).some((types) =>
       (types as readonly string[]).includes(effectiveDisplay ?? "")
     );
-    if (flags.display || isTrackedDisplay) {
+    if (isTrackedDisplay) {
       validateWidgetEnums(effectiveDisplay, effectiveDataset);
     }
   }

test/commands/dashboard/widget/edit.test.ts

@@ -271,6 +271,16 @@ describe("dashboard widget edit", () => {
     expect(updateDashboardSpy).toHaveBeenCalled();
   });
 
+  test("allows --display change to untracked display type (text)", async () => {
+    // Changing --display to an untracked type should also skip cross-validation.
+    const { context } = createMockContext();
+    const func = await editCommand.loader();
+    // sampleDashboard widget[0] is displayType: "big_number", widgetType: "spans"
+    // Changing to "text" should not throw even though "text" isn't in spans' supported types.
+    await func.call(context, { json: false, index: 0, display: "text" }, "123");
+    expect(updateDashboardSpy).toHaveBeenCalled();
+  });
+
   test("validates aggregates against new dataset when --dataset changes", async () => {
     const { context } = createMockContext();
     const func = await editCommand.loader();