feat(cmd): Add progress spinner during analysis#87
Merged
Joseph94m merged 1 commit intogetplumber:mainfrom Mar 3, 2026
Merged
Conversation
Add a visual progress indicator that shows analysis steps while running. The spinner displays a braille animation with a progress bar and step description, providing user feedback during potentially long API calls. - Add progressSpinner in cmd/spinner.go with animated braille frames - Add ProgressFunc callback in Configuration to decouple UI from logic - Add reportProgress/clearProgressLine helpers in control/task.go - Wire spinner in cmd/analyze.go (only when not verbose) - Install logrus hook to prevent log interleaving with spinner Closes getplumber#64
Collaborator
|
Thanks @stephrobert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64
What
Adds a visual progress indicator during
plumber analyze, showing which step is running with an animated spinner and progress bar.Changes
cmd/spinner.go: braille-animated spinner with progress bar (█/░)configuration/configuration.go:ProgressFunccallback to decouple UI from logiccontrol/task.go:reportProgress/clearProgressLinehelpers, 12 progress stepscmd/analyze.go: wires spinner (only when not verbose)Demo