sentry: disable client reports

[alxndrsn]

This is a workaround for unclean shutdown handling in Sentry SDK.

See: getodk/central#1347

What has been done to verify that this works as intended?

Tested quite a bit manually locally.

Why is this the best possible solution? Were any other approaches considered?

I think the correct solution is to always call Sentry.close(), but without relevant tests it will be:

1. hard to enforce Sentry.close() is always called, and
2. very unhelpful if a call is ever missed

Tests are also tricky to write, as the only reproduction I've found is by updating /etc/hosts, so this bug would potentially need a new suite of tests, or at least an update to the existing standard suite. Ideally these tests would:

1. call every script in lib/bin/, and
2. run the odk-central-backend service, and shut it down

and then check that all of the above processes halted within a sensible timeframe.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Should fix their issue with #1347

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

No.

Before submitting this PR, please make sure you have:

• run make test and confirmed all checks still pass OR confirm CircleCI build passes
• verified that any code from external sources are properly credited in comments or that everything is internally sourced

[yanokwa]

I'm happy with the general approach. Perhaps we can file an issue to re-enable client reports once getsentry/sentry-javascript#18802 is fixed?

[lognaturel]

This has now been fixed and released upstream: getsentry/sentry-javascript#18808

But since we want to release an improvement in a point release and client reports are not that important, I think we should release this small change and file an issue to upgrade Sentry and reintroduce client reports.

[lognaturel]

It looks like db-migration-tests never finishes and so I can't merge. Any idea what's going on? I see #1732 has the same issue @ktuite. I tried rerunning CI and ended up in the same state.

[alxndrsn]

It looks like db-migration-tests never finishes and so I can't merge. Any idea what's going on?

I think this was resolved in Slack, and related to db-migration-tests being added as a required repository check.