Skip to content

Conversation

@Elecweb
Copy link

@Elecweb Elecweb commented Nov 10, 2025


@coderabbitai
Copy link

coderabbitai bot commented Nov 10, 2025

📝 Walkthrough

Walkthrough

A conditional check in FormulaValue._copyModel is modified to explicitly preserve numeric zero values during model field copying. The condition changes from if (value) to if (value || typeof value === 'number'), ensuring that fields with numeric 0 values are included in the copied model instead of being excluded due to JavaScript's falsy evaluation of 0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Single method modification with straightforward conditional logic change
  • Requires verification that this edge case fix aligns with intended model copying behavior across the codebase
  • Consider whether other value types (strings, arrays, objects) with falsy values need similar treatment

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relatedness to the changeset. Add a pull request description explaining why the fix is needed and what problem it solves for users.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly relates to the core change: handling numeric 0 values from formulas that were previously omitted due to falsy evaluation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/value-0-formula

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b5ec8c and 52a7627.

📒 Files selected for processing (1)
  • lib/doc/cell.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: compare

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Files that got Bigger 🚨:

File raw gzip
dist/exceljs.bare.js +29 B +4 B
dist/exceljs.bare.min.js +22 B +3 B
dist/exceljs.js +29 B +3 B
dist/exceljs.min.js +22 B +6 B

@Elecweb Elecweb merged commit 9262a5c into develop Nov 10, 2025
2 checks passed
@Elecweb Elecweb deleted the fix/value-0-formula branch November 10, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants