Allow adding separators to submenus#279
Open
forfuncsake wants to merge 2 commits intogetlantern:masterfrom
Open
Allow adding separators to submenus#279forfuncsake wants to merge 2 commits intogetlantern:masterfrom
forfuncsake wants to merge 2 commits intogetlantern:masterfrom
Conversation
Fixes getlantern#170 Add implementation of separators in submenus for mac, linux and windows.
Minor logic bug in the previous commit caused separators on the top level menu not to be correctly added in macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #170
Add implementation of separators in submenus for
mac, linux and windows.
Tested on: