Skip to content

Fix double fetch #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garmr-ulfr merged 1 commit into from
Jan 2, 2026
Merged

Fix double fetch #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ func NewConfigHandler(options Options) *ConfigHandler {
if !shouldRefetch(evt.New, evt.Old) {
return
}
slog.Debug("User change detected that requires config refetch")
if err := ch.fetchConfig(); err != nil {
slog.Error("Failed to fetch config", "error", err)
}
Expand All @@ -121,9 +122,8 @@ func NewConfigHandler(options Options) *ConfigHandler {

// shouldRefetch determines whether a config refetch is needed based on user ID and account type changes.
func shouldRefetch(new, old common.UserInfo) bool {
return new != old &&
(new == nil || old == nil || // sanity check
new.LegacyToken() != old.LegacyToken() || // user ID changed
return new != nil && old != nil && old.LegacyID() != 0 &&
(new.LegacyToken() != old.LegacyToken() || // user ID changed
new.AccountType() != old.AccountType()) // changed between free and pro
}

Expand Down Expand Up @@ -170,7 +170,6 @@ func (ch *ConfigHandler) fetchConfig() error {
if ch.isClosed() {
return fmt.Errorf("config handler is closed")
}
slog.Debug("Fetching config")
var preferred C.ServerLocation
oldConfig, err := ch.GetConfig()
if err != nil {
Expand Down