misc: allow combobox to have more freedom on defining element height #2918
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| } | ||
|
|
||
| return 0 | ||
| } |
There was a problem hiding this comment.
Mismatch between estimated and actual bottom margins for items
The calculateItemMarginBottom function returns 0 for items followed by another item, but getItemHeight (used as estimateSize for the virtualizer) calculates a 4px bottom padding for the same scenario. This inconsistency causes the virtualizer's size estimates to be consistently larger than actual rendered sizes. For a list of consecutive items, estimates will be ~4px per middle item higher than actual, potentially causing visual jumpiness as items are measured and repositioned.
Additional Locations (1)
| className="relative w-full" | ||
| style={{ | ||
| height: `${virtualizerTotalSize}px`, | ||
| height: `${virtualizerTotalSize + COMBOBOX_CONFIG.ITEM_GROUP_MARGIN_BOTTOM}px`, |
There was a problem hiding this comment.
Unconditional margin addition to container height causes extra space
The container height unconditionally adds ITEM_GROUP_MARGIN_BOTTOM (8px) to virtualizerTotalSize. However, when the last element is a header (which returns 0 from calculateItemMarginBottom), this adds unnecessary space. Additionally, since getItemHeight already includes bottom margin in its estimates for the last item, this creates double-counting when the virtualizer uses estimates. The result is inconsistent extra whitespace at the bottom of the list.
Context
While working on the PR to have custom roles, the design is to have the description in the combo box elements and this created an issue.
Description
This PR changes the way we calculate combobox elements height, allowing it to take the space it needs
Fixes LAGO-XXX
Note
Enhances layout of
BaseComboBoxVirtualizedListto better handle item/header spacing and end-of-list padding.calculateItemMarginBottomand applies per-itemmarginBottom(no margin for headers; group/end spacing viaITEM_GROUP_MARGIN_BOTTOM)virtualizerTotalSize + ITEM_GROUP_MARGIN_BOTTOMto preserve bottom paddingheightstyle so items can size naturallygetItemHeight/marginToplogic to align virtualizer estimates with new spacingWritten by Cursor Bugbot for commit b910094. This will update automatically on new commits. Configure here.