Conversation
✅ Deploy Preview for gs-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Storybook to v9 and integrates Chromatic visual testing alongside Vitest for Storybook stories.
- Upgraded Storybook and related addons to the latest versions and switched imports to
vue3-vite - Configured a dedicated Vitest project for Storybook with browser (Playwright) testing and Chromatic setup
- Added Chromatic configuration and supporting setup files for visual regression testing
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Added storybookTest plugin, browser-based project settings, and merged with main Vite config |
| src/stories/*.stories.ts | Updated Storybook framework imports from @storybook/vue3 to @storybook/vue3-vite |
| .storybook/main.ts | Replaced essentials and interactions addons with docs and Vitest addons |
| package.json | Bumped Storybook, Chromatic, and added a test-storybook script |
| chromatic.config.json | Introduced Chromatic configuration (projectId, onlyChanged, zip) |
| .storybook/vitest.setup.ts | Created Vitest setup to run Storybook’s beforeAll hooks |
| .storybook/preview.ts | Switched preview imports to @storybook/vue3-vite |
Comments suppressed due to low confidence (4)
vitest.config.ts:8
- [nitpick] The variable name
dirnamemay be confused with Node’s built-in__dirname. Consider renaming it to something more descriptive, likestorybookConfigDir, to improve clarity.
const dirname =
.storybook/main.ts:7
- Removing
@storybook/addon-essentialsalso drops controls, actions, viewport, and other essential features. If those are still required, add them individually or re-add essentials.
'@chromatic-com/storybook',
package.json:77
- [nitpick] Verify that the unscoped
storybookpackage is necessary; typically Storybook is managed via scoped packages under@storybook/*rather than an unscopedstorybookdependency.
"storybook": "^9.0.15",
.storybook/vitest.setup.ts:2
- Double-check that
setProjectAnnotationsis correctly imported from the intended testing utility. The Storybook testing documentation often references@storybook/testing-vueor the addon package rather than the framework entrypoint.
import { setProjectAnnotations } from '@storybook/vue3-vite'
donatPeter
previously approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation choices:
Link to task/bug:
https://greenspark-force.monday.com/boards/3658967791/views/83096355/pulses/9290231571?userId=54391332