Conversation
✅ Deploy Preview for gs-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
Updates the Vite configuration to include helper files in type declarations and split them into a separate chunk, and streamlines the ESLint setup.
- Expanded
includeglobs and added amanualChunksrule for helpers in both TS and JS Vite configs - Removed the custom unused-vars override from the ESLint flat config
- Reformatted multiline arrays for better readability
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| vite.config.ts | Added src/helpers/*.ts to include, introduced manualChunks |
| vite.config.js | Mirrored TS config updates in JS variant |
| eslint.config.js | Dropped custom @typescript-eslint/no-unused-vars rule override |
Comments suppressed due to low confidence (1)
eslint.config.js:18
- [nitpick] The custom
@typescript-eslint/no-unused-varsoverride was removed—please confirm that dropping this rule is intentional, as it may increase linter noise.
}, skipFormatting);
| manualChunks: { | ||
| helpers: ['./src/helpers/*.ts'], |
There was a problem hiding this comment.
Rollup's manualChunks does not expand glob patterns; this array won’t be resolved. Consider using a function, e.g.: manualChunks(id) { if (id.includes('/src/helpers/')) return 'helpers'; }.
| manualChunks: { | |
| helpers: ['./src/helpers/*.ts'], | |
| manualChunks: (id) => { | |
| if (id.includes('/src/helpers/')) { | |
| return 'helpers'; | |
| } |
| manualChunks: { | ||
| helpers: ['./src/helpers/*.ts'], |
There was a problem hiding this comment.
Same issue as in the TS config: Rollup doesn't process globs here. Use a function-based manualChunks that checks id.includes('/src/helpers/').
| manualChunks: { | |
| helpers: ['./src/helpers/*.ts'], | |
| manualChunks: (id) => { | |
| if (id.includes('/src/helpers/')) { | |
| return 'helpers'; | |
| } |
No description provided.