Fix beforeunload handler crash during browser closure #2763
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When closing the browser, if a page has a beforeunload event handler, Taiko would crash with 'There is no handler registered for beforeunload popup'. This fix adds a flag to automatically accept beforeunload dialogs during browser closure, preventing the crash while still allowing explicit beforeunload handling during normal operation. Fixes getgauge#2752 Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>
Open
zabil
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2752
When closing the browser, if a page has a
beforeunloadevent handler, Taiko would crash with the error:There is no handler registered for beforeunload popup displayed on the page
This PR adds a flag-based mechanism to automatically accept
beforeunloaddialogs during browser closure, preventing the crash while still allowing explicit beforeunload handling during normal operation.Changes
isClosingBrowserflag inpageHandler.jsto track browser closure stateaddJavascriptDialogOpeningListener()to auto-accept beforeunload dialogs when closingcloseConnection()inconnection.jsto set/reset the flag