Skip to content

fix: use WSL2 host IP for OAuth callback instead of 127.0.0.1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jadoothespitz (Jadoothespitz) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use WSL2 host IP for OAuth callback instead of 127.0.0.1 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions cli/src/lib/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,20 @@ const AUTH_ENDPOINT = `${CLERK_ISSUER}/oauth/authorize`;
const TOKEN_ENDPOINT = `${CLERK_ISSUER}/oauth/token`;
const REGISTER_ENDPOINT = `${CLERK_ISSUER}/oauth/register`;
const CALLBACK_PORT = 9876;
const REDIRECT_URI = `http://127.0.0.1:${CALLBACK_PORT}/callback`;

function getListenHost() {
try {
const version = readFileSync('/proc/version', 'utf8').toLowerCase();
if (version.includes('microsoft')) {
return execSync('hostname -I').toString().trim().split(' ')[0];
}
} catch {}
return '127.0.0.1';
}

const LISTEN_HOST = getListenHost();

const REDIRECT_URI = `http://${LISTEN_HOST}:${CALLBACK_PORT}/callback`;
const USERINFO_ENDPOINT = `${CLERK_ISSUER}/oauth/userinfo`;
const SCOPES = 'profile email offline_access';

Expand Down Expand Up @@ -127,7 +140,7 @@ function startCallbackServer() {
}
});

server.listen(CALLBACK_PORT, '127.0.0.1', () => {
server.listen(CALLBACK_PORT, LISTEN_HOST, () => {
resolve(server);
});
});
Expand All @@ -141,7 +154,7 @@ function waitForCallback(server) {
}, 120000);

server.on('request', (req, res) => {
const url = new URL(req.url, `http://127.0.0.1:${CALLBACK_PORT}`);
const url = new URL(req.url, `http://${LISTEN_HOST}:${CALLBACK_PORT}`);

if (url.pathname !== '/callback') {
res.writeHead(404);
Expand Down