fix(sdk): auto-inject clientId in proxyLLMCall to match Go/Python/TypeScript SDKs #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhjain1592
force-pushed
the
fix/proxy-llm-call-client-id
branch
from
a6003a2 to
aac8a2e
Compare
…eScript SDKs Auto-populate clientId from config when not explicitly set in ClientRequest. Previously caused "client_id field is required" errors. Added to v2.7.1 changelog entry.
saurabhjain1592
force-pushed
the
fix/proxy-llm-call-client-id
branch
from
aac8a2e to
dec46d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
proxyLLMCallmethod was not auto-populatingclientIdfrom config when not explicitly set inClientRequest, unlike other SDKs:axonflow.go:562client.py:706client.ts:612This caused
"client_id field is required"errors when usingproxyLLMCallwithout explicitly settingclientIdin the request, even thoughclientIdwas configured inAxonFlowConfig.Fix
Apply the same pattern used in
getPolicyApprovedContext: auto-populateclientIdfrom config if not set in the request.Tests Added
proxyLLMCallShouldAutoInjectClientId: verifies auto-injection worksproxyLLMCallShouldPreserveExplicitClientId: verifies explicit clientId is not overwrittenTest Plan
eu-ai-act,rbi-sebi) pass with SDK fix.clientId()inClientRequest.builder()