Skip to content

fix: return app metadata and lud16 in get_info without scope #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
im-adithya wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: return app metadata and lud16 in get_info without scope #2152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
daa8f22
fix: return app metadata and lud16 in get_info without scope
im-adithya Mar 18, 2026
31eb511
chore: remove unnecessary no error check
im-adithya Mar 18, 2026
d27deab
chore: rename nodeInfo to infoResponse in get info tests
im-adithya Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions nip47/controllers/get_info_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,34 @@ func (controller *nip47Controller) HandleGetInfoEvent(ctx context.Context, nip47
Notifications: supportedNotifications,
}

if app != nil {
metadata := map[string]interface{}{}
if app.Metadata != nil {
jsonErr := json.Unmarshal(app.Metadata, &metadata)
if jsonErr != nil {
logger.Logger.WithError(jsonErr).WithFields(logrus.Fields{
"id": app.ID,
"metadata": app.Metadata,
}).Error("Failed to deserialize app metadata")
}
}
if metadata["id"] == nil {
metadata["id"] = app.ID
}
if metadata["name"] == nil {
metadata["name"] = app.Name
}
if !app.Isolated {
lightningAddress, _ := controller.albyOAuthService.GetLightningAddress()
responsePayload.LightningAddress = &lightningAddress
} else if metadata[constants.METADATA_APPSTORE_APP_ID_KEY] == constants.SUBWALLET_APPSTORE_APP_ID && metadata["lud16"] != nil {
lightningAddress := metadata["lud16"].(string)
responsePayload.LightningAddress = &lightningAddress
}

responsePayload.Metadata = metadata
}

// basic permissions check
// this is inconsistent with other methods. Ideally we move fetching node info to a separate method,
// so that get_info does not require its own scope. This would require a change in the NIP-47 spec.
Expand Down Expand Up @@ -70,34 +98,6 @@ func (controller *nip47Controller) HandleGetInfoEvent(ctx context.Context, nip47
responsePayload.Network = &network
responsePayload.BlockHeight = &info.BlockHeight
responsePayload.BlockHash = &info.BlockHash

if app != nil {
metadata := map[string]interface{}{}
if app.Metadata != nil {
jsonErr := json.Unmarshal(app.Metadata, &metadata)
if jsonErr != nil {
logger.Logger.WithError(jsonErr).WithFields(logrus.Fields{
"id": app.ID,
"metadata": app.Metadata,
}).Error("Failed to deserialize app metadata")
}
}
if metadata["id"] == nil {
metadata["id"] = app.ID
}
if metadata["name"] == nil {
metadata["name"] = app.Name
}
if !app.Isolated {
lightningAddress, _ := controller.albyOAuthService.GetLightningAddress()
responsePayload.LightningAddress = &lightningAddress
} else if metadata[constants.METADATA_APPSTORE_APP_ID_KEY] == constants.SUBWALLET_APPSTORE_APP_ID && metadata["lud16"] != nil {
lightningAddress := metadata["lud16"].(string)
responsePayload.LightningAddress = &lightningAddress
}

responsePayload.Metadata = metadata
}
}

publishResponse(&models.Response{
Expand Down
140 changes: 75 additions & 65 deletions nip47/controllers/get_info_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ func TestHandleGetInfoEvent_NoPermission(t *testing.T) {
require.NoError(t, err)
defer svc.Remove()

app, _, err := tests.CreateApp(svc)
metadata := map[string]interface{}{
"a": 123,
}

app, _, err := svc.AppsService.CreateApp("test", "", 0, "monthly", nil, []string{constants.GET_INFO_SCOPE}, false, metadata)
assert.NoError(t, err)

lightningAddress := "hello@getalby.com"
Expand Down Expand Up @@ -63,17 +67,22 @@ func TestHandleGetInfoEvent_NoPermission(t *testing.T) {
HandleGetInfoEvent(ctx, nip47Request, dbRequestEvent.ID, app, publishResponse)

assert.Nil(t, publishedResponse.Error)
nodeInfo := publishedResponse.Result.(*getInfoResponse)
assert.Nil(t, nodeInfo.Alias)
assert.Nil(t, nodeInfo.Color)
assert.Nil(t, nodeInfo.Pubkey)
assert.Nil(t, nodeInfo.Network)
assert.Nil(t, nodeInfo.BlockHeight)
assert.Nil(t, nodeInfo.BlockHash)
assert.Nil(t, nodeInfo.LightningAddress)
infoResponse := publishedResponse.Result.(*getInfoResponse)
assert.Nil(t, infoResponse.Alias)
assert.Nil(t, infoResponse.Color)
assert.Nil(t, infoResponse.Pubkey)
assert.Nil(t, infoResponse.Network)
assert.Nil(t, infoResponse.BlockHeight)
assert.Nil(t, infoResponse.BlockHash)
require.NotNil(t, infoResponse.LightningAddress)
assert.Equal(t, lightningAddress, *infoResponse.LightningAddress)
// get_info method is always granted, but does not return pubkey
assert.Contains(t, nodeInfo.Methods, models.GET_INFO_METHOD)
assert.Equal(t, []string{}, nodeInfo.Notifications)
assert.Contains(t, infoResponse.Methods, models.GET_INFO_METHOD)
assert.Equal(t, []string{}, infoResponse.Notifications)
require.NotNil(t, infoResponse.Metadata)
assert.Equal(t, float64(123), infoResponse.Metadata.(map[string]interface{})["a"])
assert.Equal(t, app.ID, infoResponse.Metadata.(map[string]interface{})["id"])
assert.Equal(t, app.Name, infoResponse.Metadata.(map[string]interface{})["name"])
}

func TestHandleGetInfoEvent_SubwalletNoPermission(t *testing.T) {
Expand Down Expand Up @@ -123,17 +132,22 @@ func TestHandleGetInfoEvent_SubwalletNoPermission(t *testing.T) {
HandleGetInfoEvent(ctx, nip47Request, dbRequestEvent.ID, app, publishResponse)

assert.Nil(t, publishedResponse.Error)
nodeInfo := publishedResponse.Result.(*getInfoResponse)
assert.Nil(t, nodeInfo.Alias)
assert.Nil(t, nodeInfo.Color)
assert.Nil(t, nodeInfo.Pubkey)
assert.Nil(t, nodeInfo.Network)
assert.Nil(t, nodeInfo.BlockHeight)
assert.Nil(t, nodeInfo.BlockHash)
assert.Nil(t, nodeInfo.LightningAddress)
infoResponse := publishedResponse.Result.(*getInfoResponse)
assert.Nil(t, infoResponse.Alias)
assert.Nil(t, infoResponse.Color)
assert.Nil(t, infoResponse.Pubkey)
assert.Nil(t, infoResponse.Network)
assert.Nil(t, infoResponse.BlockHeight)
assert.Nil(t, infoResponse.BlockHash)
require.NotNil(t, infoResponse.LightningAddress)
assert.Equal(t, lightningAddress, *infoResponse.LightningAddress)
// get_info method is always granted, but does not return pubkey
assert.Contains(t, nodeInfo.Methods, models.GET_INFO_METHOD)
assert.Equal(t, []string{}, nodeInfo.Notifications)
assert.Contains(t, infoResponse.Methods, models.GET_INFO_METHOD)
assert.Equal(t, []string{}, infoResponse.Notifications)
require.NotNil(t, infoResponse.Metadata)
assert.Equal(t, lightningAddress, infoResponse.Metadata.(map[string]interface{})["lud16"])
assert.Equal(t, app.ID, infoResponse.Metadata.(map[string]interface{})["id"])
assert.Equal(t, app.Name, infoResponse.Metadata.(map[string]interface{})["name"])
}

func TestHandleGetInfoEvent_WithPermission(t *testing.T) {
Expand Down Expand Up @@ -171,15 +185,15 @@ func TestHandleGetInfoEvent_WithPermission(t *testing.T) {
HandleGetInfoEvent(ctx, nip47Request, dbRequestEvent.ID, app, publishResponse)

assert.Nil(t, publishedResponse.Error)
nodeInfo := publishedResponse.Result.(*getInfoResponse)
assert.Equal(t, tests.MockNodeInfo.Alias, *nodeInfo.Alias)
assert.Equal(t, tests.MockNodeInfo.Color, *nodeInfo.Color)
assert.Equal(t, tests.MockNodeInfo.Pubkey, *nodeInfo.Pubkey)
assert.Equal(t, tests.MockNodeInfo.Network, *nodeInfo.Network)
assert.Equal(t, tests.MockNodeInfo.BlockHeight, *nodeInfo.BlockHeight)
assert.Equal(t, tests.MockNodeInfo.BlockHash, *nodeInfo.BlockHash)
assert.Contains(t, nodeInfo.Methods, "get_info")
assert.Equal(t, []string{}, nodeInfo.Notifications)
infoResponse := publishedResponse.Result.(*getInfoResponse)
assert.Equal(t, tests.MockNodeInfo.Alias, *infoResponse.Alias)
assert.Equal(t, tests.MockNodeInfo.Color, *infoResponse.Color)
assert.Equal(t, tests.MockNodeInfo.Pubkey, *infoResponse.Pubkey)
assert.Equal(t, tests.MockNodeInfo.Network, *infoResponse.Network)
assert.Equal(t, tests.MockNodeInfo.BlockHeight, *infoResponse.BlockHeight)
assert.Equal(t, tests.MockNodeInfo.BlockHash, *infoResponse.BlockHash)
assert.Contains(t, infoResponse.Methods, "get_info")
assert.Equal(t, []string{}, infoResponse.Notifications)
}

func TestHandleGetInfoEvent_WithMetadata(t *testing.T) {
Expand Down Expand Up @@ -224,19 +238,17 @@ func TestHandleGetInfoEvent_WithMetadata(t *testing.T) {
HandleGetInfoEvent(ctx, nip47Request, dbRequestEvent.ID, app, publishResponse)

assert.Nil(t, publishedResponse.Error)
nodeInfo := publishedResponse.Result.(*getInfoResponse)
assert.Equal(t, tests.MockNodeInfo.Alias, *nodeInfo.Alias)
assert.Equal(t, tests.MockNodeInfo.Color, *nodeInfo.Color)
assert.Equal(t, tests.MockNodeInfo.Pubkey, *nodeInfo.Pubkey)
assert.Equal(t, tests.MockNodeInfo.Network, *nodeInfo.Network)
assert.Equal(t, tests.MockNodeInfo.BlockHeight, *nodeInfo.BlockHeight)
assert.Equal(t, tests.MockNodeInfo.BlockHash, *nodeInfo.BlockHash)
assert.Equal(t, lightningAddress, *nodeInfo.LightningAddress)
assert.Contains(t, nodeInfo.Methods, "get_info")
assert.Equal(t, []string{}, nodeInfo.Notifications)

assert.NoError(t, err)
assert.Equal(t, float64(123), nodeInfo.Metadata.(map[string]interface{})["a"])
infoResponse := publishedResponse.Result.(*getInfoResponse)
assert.Equal(t, tests.MockNodeInfo.Alias, *infoResponse.Alias)
assert.Equal(t, tests.MockNodeInfo.Color, *infoResponse.Color)
assert.Equal(t, tests.MockNodeInfo.Pubkey, *infoResponse.Pubkey)
assert.Equal(t, tests.MockNodeInfo.Network, *infoResponse.Network)
assert.Equal(t, tests.MockNodeInfo.BlockHeight, *infoResponse.BlockHeight)
assert.Equal(t, tests.MockNodeInfo.BlockHash, *infoResponse.BlockHash)
assert.Equal(t, lightningAddress, *infoResponse.LightningAddress)
assert.Contains(t, infoResponse.Methods, "get_info")
assert.Equal(t, []string{}, infoResponse.Notifications)
assert.Equal(t, float64(123), infoResponse.Metadata.(map[string]interface{})["a"])
}

func TestHandleGetInfoEvent_SubwalletWithMetadata(t *testing.T) {
Expand Down Expand Up @@ -283,19 +295,17 @@ func TestHandleGetInfoEvent_SubwalletWithMetadata(t *testing.T) {
HandleGetInfoEvent(ctx, nip47Request, dbRequestEvent.ID, app, publishResponse)

assert.Nil(t, publishedResponse.Error)
nodeInfo := publishedResponse.Result.(*getInfoResponse)
assert.Equal(t, tests.MockNodeInfo.Alias, *nodeInfo.Alias)
assert.Equal(t, tests.MockNodeInfo.Color, *nodeInfo.Color)
assert.Equal(t, tests.MockNodeInfo.Pubkey, *nodeInfo.Pubkey)
assert.Equal(t, tests.MockNodeInfo.Network, *nodeInfo.Network)
assert.Equal(t, tests.MockNodeInfo.BlockHeight, *nodeInfo.BlockHeight)
assert.Equal(t, tests.MockNodeInfo.BlockHash, *nodeInfo.BlockHash)
assert.Equal(t, lightningAddress, *nodeInfo.LightningAddress)
assert.Contains(t, nodeInfo.Methods, "get_info")
assert.Equal(t, []string{}, nodeInfo.Notifications)

assert.NoError(t, err)
assert.Equal(t, float64(123), nodeInfo.Metadata.(map[string]interface{})["a"])
infoResponse := publishedResponse.Result.(*getInfoResponse)
assert.Equal(t, tests.MockNodeInfo.Alias, *infoResponse.Alias)
assert.Equal(t, tests.MockNodeInfo.Color, *infoResponse.Color)
assert.Equal(t, tests.MockNodeInfo.Pubkey, *infoResponse.Pubkey)
assert.Equal(t, tests.MockNodeInfo.Network, *infoResponse.Network)
assert.Equal(t, tests.MockNodeInfo.BlockHeight, *infoResponse.BlockHeight)
assert.Equal(t, tests.MockNodeInfo.BlockHash, *infoResponse.BlockHash)
assert.Equal(t, lightningAddress, *infoResponse.LightningAddress)
assert.Contains(t, infoResponse.Methods, "get_info")
assert.Equal(t, []string{}, infoResponse.Notifications)
assert.Equal(t, float64(123), infoResponse.Metadata.(map[string]interface{})["a"])
}

func TestHandleGetInfoEvent_WithNotifications(t *testing.T) {
Expand Down Expand Up @@ -341,13 +351,13 @@ func TestHandleGetInfoEvent_WithNotifications(t *testing.T) {
HandleGetInfoEvent(ctx, nip47Request, dbRequestEvent.ID, app, publishResponse)

assert.Nil(t, publishedResponse.Error)
nodeInfo := publishedResponse.Result.(*getInfoResponse)
assert.Equal(t, tests.MockNodeInfo.Alias, *nodeInfo.Alias)
assert.Equal(t, tests.MockNodeInfo.Color, *nodeInfo.Color)
assert.Equal(t, tests.MockNodeInfo.Pubkey, *nodeInfo.Pubkey)
assert.Equal(t, tests.MockNodeInfo.Network, *nodeInfo.Network)
assert.Equal(t, tests.MockNodeInfo.BlockHeight, *nodeInfo.BlockHeight)
assert.Equal(t, tests.MockNodeInfo.BlockHash, *nodeInfo.BlockHash)
assert.Contains(t, nodeInfo.Methods, "get_info")
assert.Equal(t, []string{"payment_received", "payment_sent"}, nodeInfo.Notifications)
infoResponse := publishedResponse.Result.(*getInfoResponse)
assert.Equal(t, tests.MockNodeInfo.Alias, *infoResponse.Alias)
assert.Equal(t, tests.MockNodeInfo.Color, *infoResponse.Color)
assert.Equal(t, tests.MockNodeInfo.Pubkey, *infoResponse.Pubkey)
assert.Equal(t, tests.MockNodeInfo.Network, *infoResponse.Network)
assert.Equal(t, tests.MockNodeInfo.BlockHeight, *infoResponse.BlockHeight)
assert.Equal(t, tests.MockNodeInfo.BlockHash, *infoResponse.BlockHash)
assert.Contains(t, infoResponse.Methods, "get_info")
assert.Equal(t, []string{"payment_received", "payment_sent"}, infoResponse.Notifications)
}
Loading