-
Notifications
You must be signed in to change notification settings - Fork 4
feat(just): import the new shared just recipe from bluefin #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @inffy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the management of 'just' recipes by integrating a new shared recipe from the Bluefin project. This change aims to centralize common 'just' commands, improving maintainability and consistency across the system. Concurrently, a specific Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request imports a new shared just recipe from Bluefin and removes the toggle-tpm2 recipe, which is presumably now included in the shared file. The changes are straightforward and align with the goal of centralizing shared functionality. I've added one suggestion to improve the consistency of file paths for the imported just files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the just recipe organization by moving the toggle-tpm2 recipe from aurora-common's local system.just file into a new shared recipe file (shared.just) that will be imported from the projectbluefin/common repository. This consolidates common functionality shared between Aurora and Bluefin variants.
Key changes:
- Removes the
toggle-tpm2recipe from aurora-common'ssystem.just - Adds import of
shared.justfrom projectbluefin/common to consolidate shared recipes - Maintains consistent import pattern with other bluefin-common files (default.just, apps.just)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| system_files/shared/usr/share/ublue-os/just/system.just | Removes the aurora-specific toggle-tpm2 recipe (6 lines) that will be moved to shared.just |
| system_files/shared/usr/share/ublue-os/just/00-entry.just | Adds import statement for the new shared.just file from projectbluefin/common |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
requires: projectbluefin/common#84