Skip to content

Conversation

@inffy
Copy link
Member

@inffy inffy commented Dec 27, 2025

@gemini-code-assist
Copy link

Summary of Changes

Hello @inffy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the management of 'just' recipes by integrating a new shared recipe from the Bluefin project. This change aims to centralize common 'just' commands, improving maintainability and consistency across the system. Concurrently, a specific toggle-tpm2 recipe has been removed from the system.just file, likely as part of this consolidation effort, requiring a related upstream pull request for full functionality.

Highlights

  • Shared Just Recipe Import: The pull request introduces an import for a new shared 'just' recipe, /usr/share/ublue-os/shared.just, into the main entry point for 'just' recipes.
  • TPM2 Recipe Removal: The toggle-tpm2 recipe, previously located in system.just, has been removed. This suggests a consolidation or relocation of this functionality, potentially into the newly imported shared recipe.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request imports a new shared just recipe from Bluefin and removes the toggle-tpm2 recipe, which is presumably now included in the shared file. The changes are straightforward and align with the goal of centralizing shared functionality. I've added one suggestion to improve the consistency of file paths for the imported just files.

@inffy inffy marked this pull request as ready for review December 27, 2025 20:48
Copilot AI review requested due to automatic review settings December 27, 2025 20:48
@inffy inffy enabled auto-merge December 27, 2025 20:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the just recipe organization by moving the toggle-tpm2 recipe from aurora-common's local system.just file into a new shared recipe file (shared.just) that will be imported from the projectbluefin/common repository. This consolidates common functionality shared between Aurora and Bluefin variants.

Key changes:

  • Removes the toggle-tpm2 recipe from aurora-common's system.just
  • Adds import of shared.just from projectbluefin/common to consolidate shared recipes
  • Maintains consistent import pattern with other bluefin-common files (default.just, apps.just)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
system_files/shared/usr/share/ublue-os/just/system.just Removes the aurora-specific toggle-tpm2 recipe (6 lines) that will be moved to shared.just
system_files/shared/usr/share/ublue-os/just/00-entry.just Adds import statement for the new shared.just file from projectbluefin/common

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant