Conversation
augusto-herrmann
left a comment
There was a problem hiding this comment.
Good job!
Wouldn't it be better if it had a separate flag in an environment variable (not just TEST_ENVIRONMENT), so that when installing the system one could choose whether or not they want the audit log? This ought to grow data storage pretty fast, and it seems reasonable that in some deployments it may not be desirable to keep those logs.
Good point @augusto-herrmann. I made some changes to use a new environment variable. In case the user disable it, will also remove the triggers to stop populating the database |
augusto-herrmann
left a comment
There was a problem hiding this comment.
Got it, remove_audit_triggers is necessary to allow the audit log setting to be disabled or re-enabled at will.
Fix #216