Skip to content

Deletion hook support#21

Closed
DanielWTQ wants to merge 1 commit intogesinn-it-pub:masterfrom
WikiTeq:deletion-hook-support
Closed

Deletion hook support#21
DanielWTQ wants to merge 1 commit intogesinn-it-pub:masterfrom
WikiTeq:deletion-hook-support

Conversation

@DanielWTQ
Copy link
Copy Markdown
Contributor

Support data update trigger upon articles deletion

@DanielWTQ
Copy link
Copy Markdown
Contributor Author

This replaces #10
The first commit is needed for CI to pass and is pending separately at #20

Support data update trigger upon articles deletion

Co-Authored-By: Vedmaka <god.vedmaka@gmail.com>
@DanielWTQ DanielWTQ force-pushed the deletion-hook-support branch from 74af54e to cd0f50a Compare November 12, 2025 20:44
@DanielWTQ
Copy link
Copy Markdown
Contributor Author

Rebased this, first commit was merged in 0fe5afe

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.07%. Comparing base (0fe5afe) to head (cd0f50a).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/Hooks.php 55.55% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #21      +/-   ##
============================================
- Coverage     72.22%   64.07%   -8.15%     
- Complexity       28       32       +4     
============================================
  Files             1        1              
  Lines            90      103      +13     
============================================
+ Hits             65       66       +1     
- Misses           25       37      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vedmaka
Copy link
Copy Markdown
Contributor

vedmaka commented Nov 17, 2025

I tested this patch on SMW 6.x, and confirmed it works as expected

@gesinn-it-gea
Copy link
Copy Markdown
Collaborator

Dear all, sorry for the delayed response to this PR. We will integrate your proposals into the current code base.

@gesinn-it-gea
Copy link
Copy Markdown
Collaborator

Done in https://github.com/gesinn-it-pub/SemanticDependencyUpdater/releases/tag/4.2.0

@gesinn-it-gea
Copy link
Copy Markdown
Collaborator

A sh.. Just saw, that CI breaks for MW 1.39 because of the updated DeferredUpdates import for MediaWiki 1.43. I'll prepare a 5.x release ....

@gesinn-it-gea gesinn-it-gea reopened this Feb 3, 2026
@gesinn-it-gea
Copy link
Copy Markdown
Collaborator

now we are good. Either v4.2.0 or v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants