Deletion hook support#21
Closed
DanielWTQ wants to merge 1 commit intogesinn-it-pub:masterfrom
Closed
Conversation
Contributor
Author
Support data update trigger upon articles deletion Co-Authored-By: Vedmaka <god.vedmaka@gmail.com>
74af54e to
cd0f50a
Compare
Contributor
Author
|
Rebased this, first commit was merged in 0fe5afe |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21 +/- ##
============================================
- Coverage 72.22% 64.07% -8.15%
- Complexity 28 32 +4
============================================
Files 1 1
Lines 90 103 +13
============================================
+ Hits 65 66 +1
- Misses 25 37 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I tested this patch on SMW 6.x, and confirmed it works as expected |
Collaborator
|
Dear all, sorry for the delayed response to this PR. We will integrate your proposals into the current code base. |
Collaborator
Collaborator
|
A sh.. Just saw, that CI breaks for MW 1.39 because of the updated DeferredUpdates import for MediaWiki 1.43. I'll prepare a 5.x release .... |
Collaborator
|
now we are good. Either v4.2.0 or v5.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support data update trigger upon articles deletion