fix: report open unresolved codex findings in summary#19
fix: report open unresolved codex findings in summary#19
Conversation
cli/review/dedupe.py
Outdated
| if not isinstance(comments_value, list): | ||
| return None | ||
|
|
||
| for comment in comments_value: |
There was a problem hiding this comment.
🔴 [P1] cli/review/dedupe.py:190 counts non-Codex reviewers as Codex findings
Current code:
for comment in comments_value:
if not isinstance(comment, dict):
continue
body_value = comment.get("body")
if not isinstance(body_value, str):
continueProblem: Any unresolved comment with a [P0-P3] tag is treated as a Codex finding even when written by another reviewer, so unrelated threads can force the summary to “patch is incorrect”.
Fix:
user_value = comment.get("user")
login = user_value.get("login") if isinstance(user_value, dict) else ""
if login and login not in {"github-actions[bot]", "codex-bot"}:
continue
body_value = comment.get("body")
if not isinstance(body_value, str):
continue
cli/review/dedupe.py
Outdated
| if not isinstance(comments_value, list): | ||
| return None | ||
|
|
||
| for comment in comments_value: |
There was a problem hiding this comment.
🟡 [P2] cli/review/dedupe.py:190 choose latest Codex comment in thread
Current code:
for comment in comments_value:
if not isinstance(comment, dict):
continue
body_value = comment.get("body")Problem: Uses oldest matching comment; misses newer, higher-priority updates.
Fix:
for comment in reversed(comments_value):
cli/workflows/review_workflow.py
Outdated
| def _canonical_overall_correctness(value: str) -> str: | ||
| return ( | ||
| "patch is incorrect" | ||
| if value.strip().lower() == "patch is incorrect" |
There was a problem hiding this comment.
⚪ [P3] cli/workflows/review_workflow.py:86 normalize trailing punctuation in verdict
Current code:
return (
"patch is incorrect"
if value.strip().lower() == "patch is incorrect"
else "patch is correct"
)Problem: Trailing period in model output misclassifies as correct.
Fix:
if value.strip().lower().rstrip(".") == "patch is incorrect"|
Codex Autonomous Review:
No new, non-duplicative issues found. Changes introduce prior-finding extraction, reconciliation, and summary counters without breaking existing behavior; tests cover the new logic and pass locally. Applicable prior Codex blocking findings (P0/P1) remain unresolved by current code. Tip: comment with "/codex address comments" to attempt automated fixes for unresolved review threads. |
No description provided.