Skip to content

fix: report open unresolved codex findings in summary#19

Closed
gersmann wants to merge 4 commits intomainfrom
feat/better-totals/sg
Closed

fix: report open unresolved codex findings in summary#19
gersmann wants to merge 4 commits intomainfrom
feat/better-totals/sg

Conversation

@gersmann
Copy link
Owner

No description provided.

if not isinstance(comments_value, list):
return None

for comment in comments_value:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 [P1] cli/review/dedupe.py:190 counts non-Codex reviewers as Codex findings

Current code:

    for comment in comments_value:
        if not isinstance(comment, dict):
            continue

        body_value = comment.get("body")
        if not isinstance(body_value, str):
            continue

Problem: Any unresolved comment with a [P0-P3] tag is treated as a Codex finding even when written by another reviewer, so unrelated threads can force the summary to “patch is incorrect”.

Fix:

        user_value = comment.get("user")
        login = user_value.get("login") if isinstance(user_value, dict) else ""
        if login and login not in {"github-actions[bot]", "codex-bot"}:
            continue

        body_value = comment.get("body")
        if not isinstance(body_value, str):
            continue

Repository owner deleted a comment from github-actions bot Feb 12, 2026
if not isinstance(comments_value, list):
return None

for comment in comments_value:
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 [P2] cli/review/dedupe.py:190 choose latest Codex comment in thread

Current code:

    for comment in comments_value:
        if not isinstance(comment, dict):
            continue

        body_value = comment.get("body")

Problem: Uses oldest matching comment; misses newer, higher-priority updates.

Fix:

    for comment in reversed(comments_value):

def _canonical_overall_correctness(value: str) -> str:
return (
"patch is incorrect"
if value.strip().lower() == "patch is incorrect"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ [P3] cli/workflows/review_workflow.py:86 normalize trailing punctuation in verdict

Current code:

    return (
        "patch is incorrect"
        if value.strip().lower() == "patch is incorrect"
        else "patch is correct"
    )

Problem: Trailing period in model output misclassifies as correct.

Fix:

        if value.strip().lower().rstrip(".") == "patch is incorrect"

@github-actions github-actions bot deleted a comment from gersmann Feb 12, 2026
Repository owner deleted a comment from github-actions bot Feb 12, 2026
@github-actions github-actions bot deleted a comment from gersmann Feb 12, 2026
Repository owner deleted a comment from github-actions bot Feb 13, 2026
@gersmann
Copy link
Owner Author

Codex Autonomous Review:

  • Overall: patch is incorrect
  • Findings (new): 0
  • Findings (applicable prior): 1
  • Applicable prior blocking findings (P0/P1): 1
  • Highest applicable prior priority: P1

No new, non-duplicative issues found. Changes introduce prior-finding extraction, reconciliation, and summary counters without breaking existing behavior; tests cover the new logic and pass locally. Applicable prior Codex blocking findings (P0/P1) remain unresolved by current code.

Tip: comment with "/codex address comments" to attempt automated fixes for unresolved review threads.

@gersmann gersmann closed this Feb 13, 2026
@gersmann gersmann deleted the feat/better-totals/sg branch February 13, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant