Add bwidget dependency, detail Xmu requirement, fix Togl download pat… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue reported where `spack env depfile` + `make -j` would
non-deterministically refuse to mark all environment roots explicit.
`update_explicit` had the pattern
```python
rec = self._data[key]
with self.write_transaction():
rec.explicit = explicit
```
but `write_transaction` may reinitialize `self._data`, meaning that
mutating `rec` won't mutate `self._data`, and the changes won't be
persisted.
Instead, use `mark` which has a correct implementation.
Also avoids the essentially incorrect early return in `update_explicit`
which is a pattern I don't think belongs in database.py: it branches on
possibly stale data to realize there is nothing to change, but in reality
it requires a write transaction to know that for a fact, but that would
defeat the purpose. So, leave this optimization to the call site.
* Introduce support for ArmPL and ACfL 24.10 This patch introduces the possibility of installing armpl-gcc and acfl 24.10 through spack. It also addressed one issue observed after PR spack#46594 * Fix Github action issues. - Remove default URL - Reinstate default OS for ACfL to RHEL.
Co-authored-by: Scot Halverson <shalverson@nvidia.com>
- Merging sycl2020usm and sycl2020acc into sycl2020 and the submodel=acc/usm variant is introduced - implementation is renamed to option - impl ( fortran implementation options) renamed to foption - sycl_compiler_implementation and thrust_backend - stddata,stdindices,stdranges to a single std with std_submodel introduction - std_use_tbb to be boolean; also changed model filtering algorithm to make sure that it only picks model names - Modified comments to clear confusion with cuda_arch cc_ and sm_ prefix appends - Deleted duplicate of cuda_arch definition from +omp - CMAKE_CXX_COMPILER moved to be shared arg between all models except tbb and thrust - Replaced sys.exit with InstallError and created a dictionary to simplify things and eliminate excess code lines doing same checks - Replaced the -mcpu flags to -march since it is deprecated now - Replaced platform.machine with spec.target - Removing raja_backend, introducing openmp_flag,removing -march flags,clearing debugging print(), removing excess if ___ in self.spec.variants - [FIX] Issue where Thrust couldn't find correct compiler (it requires nvcc) - [FIX] Fortran unsupported check to match the full string - [FIX] RAJA cuda_arch to be with sm_ not cc_ - dir= option is no longer needed for kokkos - dir is no longer needed - [omp] Adding clang support for nvidia offload - SYCL2020 offload to nvidia GPU - changing model dependency to be languages rather than build system - removing hardcoded arch flags and replacing with archspec - removing cpu_arch from acc model --------- Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> Co-authored-by: Greg Becker <becker33@llnl.gov> Co-authored-by: Kaan Olgu <kaan.olgu@bristol.ac.uk> Co-authored-by: Todd Gamblin <tgamblin@llnl.gov>
…pack#45592) Bumps [docutils](https://docutils.sourceforge.io) from 0.20.1 to 0.21.2. --- updated-dependencies: - dependency-name: docutils dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
* geant4: make downloading data dependency optional This PR makes downloading the data repository of the Geant4 spec optional by adding a sticky, default-enabled variant which controls the dependency on `geant4-data`. This should not change the default behaviour, but should allow users to choose whether or not they want the data directory. * Add comment * Update env variable * Generic docs * Buildable false
* cp2k: protect against newer libxc * Compat bound for libxc
* Add openfast version 3.5.4 * remove commits
This changes `Spec` serialization to include information about propagation for abstract specs. This was previously not included in the JSON representation for abstract specs, and couldn't be stored. Now, there is a separate `propagate` dictionary alongside the `parameters` dictionary. This isn't beautiful, but when we bump the spec version for Spack `v0.24`, we can clean up this and other aspects of the schema.
* don't concretize in CI if changed packages are not in stacks Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> * Generate noop job when no specs to rebuild due to untouched pruning * Add test to verify skipping generate creates a noop job * Changed debug for early exit --------- Signed-off-by: Todd Gamblin <tgamblin@llnl.gov> Co-authored-by: Todd Gamblin <tgamblin@llnl.gov>
Currently, the `concretizer:unify:` config option only affects environments. With this PR, it now affects any group of specs given to a command using the `parse_specs(*, concretize=True)` interface. - [x] implementation in `parse_specs` - [x] tests - [x] ensure all commands that accept multiple specs and concretize use `parse_specs` interface --------- Co-authored-by: Todd Gamblin <tgamblin@llnl.gov> Signed-off-by: Todd Gamblin <tgamblin@llnl.gov>
Bumps [python-levenshtein](https://github.com/rapidfuzz/python-Levenshtein) from 0.26.0 to 0.26.1. - [Release notes](https://github.com/rapidfuzz/python-Levenshtein/releases) - [Changelog](https://github.com/rapidfuzz/python-Levenshtein/blob/main/HISTORY.md) - [Commits](rapidfuzz/python-Levenshtein@v0.26.0...v0.26.1) --- updated-dependencies: - dependency-name: python-levenshtein dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Currently, the schema reads:
from:
- type:
environment: path_or_name
but this can't be extended easily to other types, e.g. to buildcaches,
without duplicating the extension keys. Use instead:
from:
- type: environment
path: path_or_name
According to root-project/root#7160, if `-Dcocoa=ON` build must also be configured with `-Dopengl=ON`, since otherwise the build encounters missing includes. This is/was a silent failure in ROOT CMake, but I believe has been made an explicit failure some time this year.
* sherpa: add v3.0.1 * sherpa: no depends_on py-setuptools
* pythia8: add v8.312 * pythia8: update homepage url
This PR changes the semantic of == for spec so that: hdf5++mpi == hdf5+mpi won't hold true anymore. It also changes the constrain semantic, so that a non-propagating variant always override a propagating variant. This means: (hdf5++mpi).constrain(hdf5+mpi) -> hdf5+mpi Before we had a very weird semantic, that was supposed to be tested by unit-tests: (libelf++debug).constrain(libelf+debug+foo) -> libelf++debug++foo This semantic has been dropped, as it was never really tested due to the == bug.
Since macOS 15 `ld -single_module` warns with a deprecation message, which makes configure scripts believe the flag is unsupported. That in turn triggers a code path where `archive_cmds` is set to ``` $CC -r -keep_private_externs -nostdlib ... -dynamiclib ``` instead of just ``` $CC -dynamiclib ... ``` This code path was meant to trigger only on ancient macOS <= 14.4 where libtool had to add `-single_module`, which is the default since macos 14.4, and is now apparently deprecated because the flag is a no-op for more than 15 years. The wrong `archive_cmds` causes actual problems combined with a bug in OpenMPI's compiler wrapper (`CC=mpicc`), which appends `-rpath` flags, which cause an error when combined with the `-r` flag added by the autotools. Spack's compiler wrapper doesn't do this, but it's likely there are other compiler wrappers out there that are not aware that `-r` and `-rpath` cannot be combined. The fix is to change defaults: `lt_cv_apple_cc_single_mod=yes`.
fixes a bug where `x86_64:` and `ppc64le:` intersected, and x86_64: and :haswell did not.
* e4s cray rhel ci stack: re-enable and update for new cpe, should fix cray libsci issue * only run e4s-cray-rhel stack * Mkae Autotools build_system point at correct build_directory * remove selective enable of cray-rhel stacks * restore SPACK_CI_DISABLE_STACKS * use dot prefix to hide cray-sles jobs instead of comment-out --------- Co-authored-by: Ryan Krattiger <ryan.krattiger@kitware.com>
* Fix hash change due to None vs {}
* Enforce null for empty list of external_modules
…#38306) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@3b5e802...44ea916) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
cupy 12 needs a newer version of cudnn as documented here. Supercedes spack#46128 Co-authored-by: Robert Underwood <runderwood@anl.gov>
* py-cython: add v3.0.11 Add url for cython because they are using lower case for 3.0.11 Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com> * Don't use f-string * Remove old version directive for 3.0.11 --------- Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com> Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
…9451) Co-authored-by: github-actions <github-actions@users.noreply.github.com>
Author
|
I've just rebased on to develop to allow for current merging - excuse the commit spam. |
Author
|
Found a couple of other environment issues for xcrysden - now it seems to work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h, and add -fcommon to compilation flags.